jshint for modules

Author: dhilt

Gruntfile.js

@@ -60,22 +60,11 @@ module.exports = function (grunt) {
       }
     },
     jshint: {
-      dist: {
-        files: {
-          src: [
-            './dist/ui-scroll.js',
-            './dist/ui-scroll-jqlite.js'
-          ]
-        },
-        options: {
-          jshintrc: '.jshintrc'
-        }
-      },
       src: {
         files: {
           src: [
-            './src/ui-scroll.js',
-            './src/ui-scroll-jqlite.js'
+            './src/*.js',
+            './src/modules/*.js'
           ]
         },
         options: grunt.util._.extend({}, grunt.file.readJSON('.jshintrc'), grunt.file.readJSON('./src/.jshintrc'))
@@ -125,6 +114,7 @@ module.exports = function (grunt) {
   ]);
 
   grunt.registerTask('buildWatcher', [
+    'jshint:src',
     'webpack',
     'copy:sources'
   ]);

src/modules/elementRoutines.js

@@ -1,8 +1,9 @@
 export default class ElementRoutines {
 
-  constructor($injector) {
+  constructor($injector, $q) {
     this.$animate = ($injector.has && $injector.has('$animate')) ? $injector.get('$animate') : null;
     this.isAngularVersionLessThen1_3 = angular.version.major === 1 && angular.version.minor < 3;
+    this.$q = $q;
   }
 
   insertElement(newElement, previousElement) {
@@ -18,11 +19,11 @@ export default class ElementRoutines {
 
   insertElementAnimated(newElement, previousElement) {
     if (!this.$animate) {
-      return insertElement(newElement, previousElement);
+      return this.insertElement(newElement, previousElement);
     }
 
     if (this.isAngularVersionLessThen1_3) {
-      const deferred = $q.defer();
+      const deferred = this.$q.defer();
       // no need for parent - previous element is never null
       this.$animate.enter(newElement, null, previousElement, () => deferred.resolve());
 
@@ -35,11 +36,11 @@ export default class ElementRoutines {
 
   removeElementAnimated(wrapper) {
     if (!this.$animate) {
-      return removeElement(wrapper);
+      return this.removeElement(wrapper);
     }
 
     if (this.isAngularVersionLessThen1_3) {
-      const deferred = $q.defer();
+      const deferred = this.$q.defer();
       this.$animate.leave(wrapper.element, () => {
         wrapper.scope.$destroy();
         return deferred.resolve();

src/modules/viewport.js

@@ -1,4 +1,4 @@
-import Padding from './padding'
+import Padding from './padding';
 
 export default function Viewport(elementRoutines, buffer, element, viewportController, padding) {
   let topPadding = null;

src/ui-scroll-grid.js

@@ -31,7 +31,7 @@ angular.module('ui.scroll.grid', [])
 
       this.exchangeWith = (index) => controller.exchangeWith(column, index);
 
-      Object.defineProperty(this, 'columnId', {get: () => column.id})
+      Object.defineProperty(this, 'columnId', {get: () => column.id});
     }
 
     function ColumnController(controller, columns, header) {
@@ -234,10 +234,10 @@ angular.module('ui.scroll.grid', [])
         controllers[0].gridController = controllers[0].gridController || new GridController(controllers[0]);
         controllers[0].gridController.registerColumn(element);
       }
-    }
+    };
   }])
 
-  .directive('uiScrollTd', ['$log', function () {
+  .directive('uiScrollTd', function () {
     return {
       require: ['?^^uiScrollViewport'],
       restrict: 'A',
@@ -249,5 +249,5 @@ angular.module('ui.scroll.grid', [])
           }
         }
       }
-    }
-  }]);
+    };
+  });

src/ui-scroll.js

@@ -81,7 +81,7 @@ angular.module('ui.scroll', [])
         let ridActual = 0;// current data revision id
         let pending = [];
 
-        let elementRoutines = new ElementRoutines($injector);
+        let elementRoutines = new ElementRoutines($injector, $q);
         let buffer = new ScrollBuffer(elementRoutines, bufferSize);
         let viewport = new Viewport(elementRoutines, buffer, element, viewportController, padding);
         let adapter = new Adapter($rootScope, $parse, $attr, viewport, buffer, adjustBuffer, element);