new test for removing out-of-buffer: remove after remove (top)

Author: dhilt

test/PaddingCacheSpec.js

@@ -6,7 +6,7 @@ describe('uiScroll Paddings cache', function () {
   beforeEach(module('ui.scroll.test.datasources'));
 
   describe('applyUpdates tests\n', function () {
-    var itemsCount = 20;
+    var itemsCount = 30;
     var itemHeight = 100;
     var viewportHeight = 500;
     var MAX = 999999;
@@ -56,15 +56,15 @@ describe('uiScroll Paddings cache', function () {
       runTest(scrollSettings,
         function (viewport, scope) {
 
-          scrollBottom(viewport, 2);
+          scrollBottom(viewport, 3);
           scrollTop(viewport);
 
           var initialBottomHeight = getBottomPaddingHeight(viewport);
           removeLastItem();
           scope.adapter.applyUpdates(itemsCount, []);
           expect(getBottomPaddingHeight(viewport)).toBe(initialBottomHeight - itemHeight);
 
-          scrollBottom(viewport, 2);
+          scrollBottom(viewport, 3);
           expect(viewport.scrollTop()).toBe(itemsCount * itemHeight - viewportHeight - itemHeight );
         }
       );
@@ -82,7 +82,7 @@ describe('uiScroll Paddings cache', function () {
       runTest(scrollSettings,
         function (viewport, scope) {
 
-          scrollBottom(viewport, 2);
+          scrollBottom(viewport, 3);
 
           var initialTopHeight = getTopPaddingHeight(viewport);
           removeFirstItem();
@@ -95,6 +95,33 @@ describe('uiScroll Paddings cache', function () {
       );
     });
 
+    it('should delete first row and then second row when out of buffer', function () {
+      var removeFirstItem;
+      inject(function(myResponsiveDatasource) {
+        var datasource = myResponsiveDatasource;
+        removeFirstItem = function() {
+          datasource.data.shift();
+          datasource.min++;
+        };
+      });
+      runTest(scrollSettings,
+        function (viewport, scope) {
+
+          scrollBottom(viewport, 3);
+
+          var initialTopHeight = getTopPaddingHeight(viewport);
+          scope.adapter.applyUpdates(1, []);
+          removeFirstItem();
+          scope.adapter.applyUpdates(2, []);
+          removeFirstItem();
+          expect(getTopPaddingHeight(viewport)).toBe(initialTopHeight - itemHeight * 2);
+
+          scrollTop(viewport);
+          expect(getTopPaddingHeight(viewport)).toBe(0);
+        }
+      );
+    });
+
   });
 
 });

test/datasources.js

@@ -199,7 +199,7 @@ angular.module('ui.scroll.test.datasources', [])
             var datasource = {
                 data: [],
                 min: 1,
-                max: 20,
+                max: 30,
                 init: function() {
                     for (var i = this.min; i <= this.max; i++) {
                         this.data.push('item' + i);