out-of-buffer demo, interim build

Author: dhilt

demo/outOfBuffer/outOfBuffer.js

@@ -83,13 +83,30 @@ app.factory('Server', [
         return this.returnDeferredResult(newItem);
       },
 
+      removeFirst: function () {
+        var firstItem = this.data.find(i => i.index === this.firstIndex);
+        if(!firstItem) {
+          return;
+        }
+        return this.removeItemById(firstItem.id);
+      },
+
+      removeLast: function () {
+        var lastItem = this.data.find(i => i.index === this.lastIndex);
+        if(!lastItem) {
+          return;
+        }
+        return this.removeItemById(lastItem.id);
+      },
+
       removeItemById: function (itemId) {
         var length = this.data.length;
         for (var i = 0; i < length; i++) {
           if (this.data[i].id === itemId) {
+            var indexRemoved = this.data[i].index;
             this.data.splice(i, 1);
             this.setIndicies();
-            return this.returnDeferredResult(true);
+            return this.returnDeferredResult(indexRemoved);
           }
         }
         return this.returnDeferredResult(false);
@@ -171,7 +188,7 @@ app.controller('mainController', [
 
     ctrl.remove = function (itemRemove) {
       Server.removeItemById(itemRemove.id).then(function (result) {
-        if (result) {
+        if (result !== false) {
           ctrl.adapter.applyUpdates(function (item) {
             if (item.id === itemRemove.id) {
               return [];
@@ -181,31 +198,20 @@ app.controller('mainController', [
       });
     };
 
-    ctrl.removeLast = function () {
-      const lastIndex = Server.lastIndex;
-      const lastItem = Server.data.find(i => i.index === Server.lastIndex);
-      if(!lastItem) {
-        return;
-      }
-      Server.removeItemById(lastItem.id).then(function (result) {
-        if (result) {
-          ctrl.adapter.applyUpdates(lastIndex, []);
+    ctrl.removeFirst = function () {
+      Server.removeFirst().then(function (indexRemoved) {
+        if (indexRemoved !== false) {
+          ctrl.adapter.applyUpdates(indexRemoved, []);
         }
       });
     };
 
-    ctrl.removeFirst = function () {
-      const firstIndex = Server.firstIndex;
-      const firstItem = Server.data.find(i => i.index === Server.firstIndex);
-      if(!firstItem) {
-        return;
-      }
-      Server.removeItemById(firstItem.id).then(function (result) {
-        if (result) {
-          ctrl.adapter.applyUpdates(firstIndex, []);
+    ctrl.removeLast = function () {
+      Server.removeLast().then(function (indexRemoved) {
+        if (indexRemoved !== false) {
+          ctrl.adapter.applyUpdates(indexRemoved, []);
         }
       });
     };
-
   }
 ]);

dist/ui-scroll.js

@@ -5,11 +5,10 @@ describe('uiScroll Paddings cache', function () {
   beforeEach(module('ui.scroll'));
   beforeEach(module('ui.scroll.test.datasources'));
 
-  describe('applyUpdates tests\n', function () {
+  describe('applyUpdates out of buffer\n', function () {
     var itemsCount = 30;
     var itemHeight = 100;
     var viewportHeight = 500;
-    var MAX = 999999;
 
     var scrollSettings = {
       datasource: 'myResponsiveDatasource',
@@ -32,7 +31,7 @@ describe('uiScroll Paddings cache', function () {
 
     function scrollBottom(viewport, count = 1) {
       for (var i = 0; i < count; i++) {
-        viewport.scrollTop(MAX);
+        viewport.scrollTop(99999);
         viewport.trigger('scroll');
       }
     }