jshint tests refactoring and improvements

Author: dhilt

package.json

@@ -24,7 +24,7 @@
     "dev-build": "webpack --config webpack/config.js",
     "dev-server": "webpack-dev-server --config webpack/config.js",
     "dev-test": "karma start test/config/karma.conf.js",
-    "hint-tests": "jshint test/*Spec.js",
+    "hint-tests": "jshint --verbose test",
     "start": "npm run dev-server",
     "test": "npm run hint-tests && npm run dev-test",
     "build": "npm run prod-build && npm run prod-test"

test/.jshintrc

@@ -1,22 +1,32 @@
 {
-  "node": true,
+  "bitwise": true,
+  "curly": true,
+  "browser": true,
+  "eqeqeq": true,
   "expr": true,
-  "sub": true,
   "esversion": 6,
+  "forin": true,
+  "freeze": true,
+  "futurehostile": true,
+  "iterator": true,
+  "jasmine": true,
+  "jquery": true,
+  "latedef": true,
+  "noarg": true,
+  "nocomma": true,
+  "node": true,
+  "nonbsp": true,
+  "nonew": true,
+  "smarttabs": true,
+  "strict": true,
+  "sub": true,
+  "trailing": true,
+  "undef": true,
+  "unused": true,
   "globals": {
-    "angular2": false,
+    "angular": false,
     "inject": false,
-    "jQuery": false,
-    "jasmine": false,
-    "afterEach": false,
-    "beforeEach": false,
-    "ddescribe": false,
-    "describe": false,
-    "expect": false,
-    "iit": false,
-    "it": false,
-    "spyOn": false,
-    "xdescribe": false,
-    "xit": false
+    "runTest": false,
+    "runGridTest": false
   }
 }

test/AdapterTestsSpec.js

@@ -36,7 +36,7 @@ describe('uiScroll', function () {
         function (viewport, scope) {
 
           scope.adapter.applyUpdates(
-            function (item, scope) {
+            function(item, scope){
               return [item + ' *' + scope.$index];
             }
           );
@@ -67,8 +67,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item, scope) {
-              if (item === 'one')
+              if (item === 'one') {
                 return [item + ' *' + scope.$index];
+              }
             }
           );
 
@@ -99,8 +100,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item, scope) {
-              if (item === 'two')
+              if (item === 'two') {
                 return [item + ' *' + scope.$index];
+              }
             }
           );
 
@@ -131,8 +133,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item, scope) {
-              if (item === 'three')
+              if (item === 'three') {
                 return [item + ' *' + scope.$index];
+              }
             }
           );
 
@@ -163,8 +166,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item) {
-              if (item === 'one')
+              if (item === 'one') {
                 return [];
+              }
             }
           );
 
@@ -191,8 +195,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item) {
-              if (item === 'two')
+              if (item === 'two') {
                 return [];
+              }
             }
           );
 
@@ -219,8 +224,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item) {
-              if (item === 'three')
+              if (item === 'three') {
                 return [];
+              }
             }
           );
 
@@ -247,8 +253,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item) {
-              if (item === 'one')
+              if (item === 'one') {
                 return ['before one', item];
+              }
             }
           );
 
@@ -284,8 +291,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item) {
-              if (item.text === 'one')
+              if (item.text === 'one') {
                 return [item, {text: 'after one'}];
+              }
             }
           );
 
@@ -320,8 +328,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item) {
-              if (item === 'two')
+              if (item === 'two') {
                 return ['before two', item];
+              }
             }
           );
 
@@ -356,8 +365,9 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item) {
-              if (item === 'three')
+              if (item === 'three') {
                 return [item, 'after three'];
+              }
             }
           );
 
@@ -798,7 +808,7 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item, scope) {
-              if (scope.$index == 1) {
+              if (scope.$index === 1) {
                 item.text += ' *' + scope.$index;
                 return [
                   {text: item.text + ' before 1'},
@@ -855,7 +865,7 @@ describe('uiScroll', function () {
 
           scope.adapter.applyUpdates(
             function (item, scope) {
-              if (scope.$index == 2) {
+              if (scope.$index === 2) {
                 item.text += ' *' + scope.$index;
                 return [
                   {text: item.text + ' before 1'},

test/config/karma.conf.js

@@ -1,6 +1,6 @@
 const chrome = process.platform === 'linux' ? 'Chromium' : 'Chrome';
 const firefox = 'Firefox';
-const ie = 'IE';
+//const ie = 'IE';
 
 const ENV = (process.env.npm_lifecycle_event.indexOf('dev') === 0) ? 'development' : 'production';
 
@@ -12,6 +12,8 @@ const webpackSettings = ENV === 'development' ? {
 } : {};
 
 module.exports = function (config) {
+  'use strict';
+
   config.set(Object.assign({
 
     basePath: '',