Skip to content

Commit 055d9c3

Browse files
clydinfilipesilva
authored andcommitted
fix(@angular-devkit/build-angular): correct Windows paths in ivy i18n extract
POSIX path handling was errantly being used to resolve paths which does not handle Windows drive letters.
1 parent dc6baf6 commit 055d9c3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ jobs:
313313
- custom_attach_workspace
314314
- setup_windows
315315
# Run partial e2e suite on PRs only. Master will run the full e2e suite with sharding.
316-
- run: if (Test-Path env:CIRCLE_PR_NUMBER) { node tests\legacy-cli\run_e2e.js "--glob=tests/{basic,ivy}/**" }
316+
- run: if (Test-Path env:CIRCLE_PR_NUMBER) { node tests\legacy-cli\run_e2e.js "--glob={tests/basic/**,tests/i18n/extract-ivy.ts}" }
317317

318318
e2e-cli-win:
319319
executor: windows-executor

packages/angular_devkit/build_angular/src/extract-i18n/ivy-extract-loader.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export default function localizeExtractLoader(
4747
let filename = loaderContext.resourcePath;
4848
if (map?.file) {
4949
// The extractor's internal sourcemap handling expects the filenames to match
50-
filename = nodePath.posix.join(loaderContext.context, map.file);
50+
filename = nodePath.join(loaderContext.context, map.file);
5151
}
5252

5353
// Setup a virtual file system instance for the extractor
@@ -64,13 +64,13 @@ export default function localizeExtractLoader(
6464
}
6565
},
6666
resolve(...paths: string[]): string {
67-
return nodePath.posix.resolve(...paths);
67+
return nodePath.resolve(...paths);
6868
},
6969
exists(path: string): boolean {
7070
return path === filename || path === filename + '.map';
7171
},
7272
dirname(path: string): string {
73-
return nodePath.posix.dirname(path);
73+
return nodePath.dirname(path);
7474
},
7575
};
7676

0 commit comments

Comments
 (0)