Skip to content

Commit 060f56d

Browse files
devversionalan-agius4
authored andcommitted
build: update ng-dev setup to work with new ESM version
The `ng-dev` tool is now strict ESM. Config loading needs to be updated to also emit `.mjs` with `ts-node` (this cannot happen dynamically as ESM Node loading cannot be patched by ts-node at runtime).
1 parent 96b5a31 commit 060f56d

File tree

14 files changed

+1140
-166
lines changed

14 files changed

+1140
-166
lines changed
File renamed without changes.

.ng-dev/commit-message.mts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import { CommitMessageConfig } from '@angular/dev-infra-private/ng-dev';
2+
import packages from '../lib/packages.js';
3+
4+
/**
5+
* The configuration for `ng-dev commit-message` commands.
6+
*/
7+
export const commitMessage: CommitMessageConfig = {
8+
maxLineLength: Infinity,
9+
minBodyLength: 0,
10+
minBodyLengthTypeExcludes: ['docs'],
11+
// Note: When changing this logic, also change the `contributing.ejs` file.
12+
scopes: [...Object.keys(packages.packages)],
13+
};

.ng-dev/commit-message.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

.ng-dev/config.mts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
export { commitMessage } from './commit-message.mjs';
2+
export { format } from './format.mjs';
3+
export { github } from './github.mjs';
4+
export { pullRequest } from './pull-request.mjs';
5+
export { release } from './release.mjs';
6+
export { caretaker } from './caretaker.mjs';

.ng-dev/config.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.
File renamed without changes.
File renamed without changes.
File renamed without changes.

.ng-dev/release.ts renamed to .ng-dev/release.mts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import '../lib/bootstrap-local';
1+
import '../lib/bootstrap-local.js';
22

33
import { ReleaseConfig } from '@angular/dev-infra-private/ng-dev';
4-
import { releasePackages } from '../lib/packages';
5-
import buildPackages from '../scripts/build';
4+
import packages from '../lib/packages.js';
5+
import buildPackages from '../scripts/build.js';
66

7-
const npmPackages = Object.entries(releasePackages).map(([name, { experimental }]) => ({
7+
const npmPackages = Object.entries(packages.releasePackages).map(([name, { experimental }]) => ({
88
name,
99
experimental,
1010
}));
@@ -13,7 +13,7 @@ const npmPackages = Object.entries(releasePackages).map(([name, { experimental }
1313
export const release: ReleaseConfig = {
1414
representativeNpmPackage: '@angular/cli',
1515
npmPackages,
16-
buildPackages: () => buildPackages(),
16+
buildPackages: () => buildPackages.default(),
1717
releaseNotes: {
1818
groupOrder: [
1919
'@angular/cli',

.ng-dev/tsconfig.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
{
22
"extends": "../tsconfig.json",
33
"compilerOptions": {
4+
"module": "Node16",
5+
"moduleResolution": "Node16",
46
"noEmit": true
57
},
6-
"include": ["**/*.ts"],
8+
"include": ["**/*.mts"],
79
"exclude": []
810
}

0 commit comments

Comments
 (0)