refactor: modernize array and string last element access using .at(-1)

Replace usages of old patterns.

Author: alan-agius4

packages/angular/build/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts

@@ -105,8 +105,7 @@ DDIy4xXPW1STWfsmSYJfYW3wa0wk+pJQ3j2cTzkPQQ8gwpvM3U9DJl43uwb37v6I
 
 async function goToPageAndWaitForWS(page: Page, url: string): Promise<void> {
   const baseUrl = url.replace(/^http/, 'ws');
-  const socksRequest =
-    baseUrl[baseUrl.length - 1] === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
+  const socksRequest = baseUrl.at(-1) === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
   // Create a Chrome dev tools session so that we can capturing websocket request.
   // https://github.com/puppeteer/puppeteer/issues/2974
 

packages/angular/build/src/builders/dev-server/tests/execute-fetch.ts

@@ -28,7 +28,7 @@ export async function executeOnceAndFetch<T>(
         let content = undefined;
         if (executionResult.result?.success) {
           let baseUrl = `${executionResult.result.baseUrl}`;
-          baseUrl = baseUrl[baseUrl.length - 1] === '/' ? baseUrl : `${baseUrl}/`;
+          baseUrl = baseUrl.at(-1) === '/' ? baseUrl : `${baseUrl}/`;
           const resolvedUrl = new URL(url, baseUrl);
           const originalResponse = await fetch(resolvedUrl, options?.request);
           response = originalResponse.clone();
@@ -68,7 +68,7 @@ export async function executeOnceAndGet<T>(
         let content = undefined;
         if (executionResult.result?.success) {
           let baseUrl = `${executionResult.result.baseUrl}`;
-          baseUrl = baseUrl[baseUrl.length - 1] === '/' ? baseUrl : `${baseUrl}/`;
+          baseUrl = baseUrl.at(-1) === '/' ? baseUrl : `${baseUrl}/`;
           const resolvedUrl = new URL(url, baseUrl);
 
           response = await new Promise<IncomingMessage>((resolve) =>

packages/angular/build/src/builders/dev-server/vite/index.ts

@@ -243,9 +243,7 @@ export async function* serveWithVite(
           const baseHref = result.detail['htmlBaseHref'] as string;
           // Remove trailing slash
           serverOptions.servePath =
-            baseHref !== './' && baseHref[baseHref.length - 1] === '/'
-              ? baseHref.slice(0, -1)
-              : baseHref;
+            baseHref !== './' && baseHref.at(-1) === '/' ? baseHref.slice(0, -1) : baseHref;
         }
 
         assetFiles.clear();

packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts

@@ -40,7 +40,7 @@ export function createAngularAssetsMiddleware(
     // The base of the URL is unused but required to parse the URL.
     const pathname = pathnameWithoutBasePath(req.url, server.config.base);
     const extension = extname(pathname);
-    const pathnameHasTrailingSlash = pathname[pathname.length - 1] === '/';
+    const pathnameHasTrailingSlash = pathname.at(-1) === '/';
 
     // Rewrite all build assets to a vite raw fs URL
     const asset = assets.get(pathname);

packages/angular/build/src/utils/project-metadata.ts

@@ -15,7 +15,7 @@ import { join } from 'node:path';
  * @returns A normalized path string.
  */
 export function normalizeDirectoryPath(path: string): string {
-  const last = path[path.length - 1];
+  const last = path.at(-1);
   if (last === '/' || last === '\\') {
     return path.slice(0, -1);
   }

packages/angular/build/src/utils/server-rendering/manifest.ts

@@ -77,7 +77,7 @@ export function generateAngularServerAppEngineManifest(
 
   // Remove trailing slash but retain leading slash.
   let basePath = baseHref || '/';
-  if (basePath.length > 1 && basePath[basePath.length - 1] === '/') {
+  if (basePath.length > 1 && basePath.at(-1) === '/') {
     basePath = basePath.slice(0, -1);
   }
 

packages/angular/build/src/utils/url.ts

@@ -22,7 +22,7 @@
  */
 export function stripTrailingSlash(url: string): string {
   // Check if the last character of the URL is a slash
-  return url.length > 1 && url[url.length - 1] === '/' ? url.slice(0, -1) : url;
+  return url.length > 1 && url.at(-1) === '/' ? url.slice(0, -1) : url;
 }
 
 /**
@@ -75,7 +75,7 @@ export function addLeadingSlash(url: string): string {
  */
 export function addTrailingSlash(url: string): string {
   // Check if the URL already end with a slash
-  return url[url.length - 1] === '/' ? url : `${url}/`;
+  return url.at(-1) === '/' ? url : `${url}/`;
 }
 
 /**
@@ -107,7 +107,7 @@ export function joinUrlParts(...parts: string[]): string {
     if (part[0] === '/') {
       normalizedPart = normalizedPart.slice(1);
     }
-    if (part[part.length - 1] === '/') {
+    if (part.at(-1) === '/') {
       normalizedPart = normalizedPart.slice(0, -1);
     }
     if (normalizedPart !== '') {

packages/angular/cli/src/command-builder/utilities/json-schema.ts

@@ -334,7 +334,7 @@ export async function parseJsonSchemaToOptions(
       // Skip any non-property items.
       return;
     }
-    const name = ptr[ptr.length - 1];
+    const name = ptr.at(-1) as string;
 
     const types = getSupportedTypes(current);
 

packages/angular/ssr/BUILD.bazel

@@ -20,7 +20,7 @@ ts_project(
     ),
     args = [
         "--lib",
-        "dom,es2020",
+        "dom,es2022",
     ],
     data = [
         "//packages/angular/ssr/third_party/beasties:beasties_bundled",

packages/angular/ssr/src/utils/url.ts

@@ -22,7 +22,7 @@
  */
 export function stripTrailingSlash(url: string): string {
   // Check if the last character of the URL is a slash
-  return url.length > 1 && url[url.length - 1] === '/' ? url.slice(0, -1) : url;
+  return url.length > 1 && url.at(-1) === '/' ? url.slice(0, -1) : url;
 }
 
 /**
@@ -75,7 +75,7 @@ export function addLeadingSlash(url: string): string {
  */
 export function addTrailingSlash(url: string): string {
   // Check if the URL already end with a slash
-  return url[url.length - 1] === '/' ? url : `${url}/`;
+  return url.at(-1) === '/' ? url : `${url}/`;
 }
 
 /**
@@ -106,7 +106,7 @@ export function joinUrlParts(...parts: string[]): string {
     if (part[0] === '/') {
       normalizedPart = normalizedPart.slice(1);
     }
-    if (part[part.length - 1] === '/') {
+    if (part.at(-1) === '/') {
       normalizedPart = normalizedPart.slice(0, -1);
     }
     if (normalizedPart !== '') {