Skip to content

Commit 2a1f4ee

Browse files
clydinalan-agius4
authored andcommitted
refactor(@angular-devkit/build-angular): remove unneeded core JsonObject type usage
The architect runtime no longer requires builder options to include the JsonObject in its type definition when calling `createBuilder`. The remaining cases in this package have been removed.
1 parent e47c4a5 commit 2a1f4ee

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

packages/angular_devkit/build_angular/src/builders/app-shell/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ async function _getServerModuleBundlePath(
154154
}
155155

156156
async function _appShellBuilder(
157-
options: JsonObject & BuildWebpackAppShellSchema,
157+
options: BuildWebpackAppShellSchema,
158158
context: BuilderContext,
159159
): Promise<BuilderOutput> {
160160
const browserTarget = targetFromTargetString(options.browserTarget);

packages/angular_devkit/build_angular/src/builders/extract-i18n/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,4 +317,4 @@ export async function execute(
317317
return webpackResult;
318318
}
319319

320-
export default createBuilder<JsonObject & ExtractI18nBuilderOptions>(execute);
320+
export default createBuilder<ExtractI18nBuilderOptions>(execute);

packages/angular_devkit/build_angular/src/builders/protractor/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
createBuilder,
1313
targetFromTargetString,
1414
} from '@angular-devkit/architect';
15-
import { JsonObject, tags } from '@angular-devkit/core';
15+
import { tags } from '@angular-devkit/core';
1616
import { resolve } from 'path';
1717
import * as url from 'url';
1818
import { runModuleAsObservableFork } from '../../utils';
@@ -171,4 +171,4 @@ export async function execute(
171171
}
172172
}
173173

174-
export default createBuilder<JsonObject & ProtractorBuilderOptions>(execute);
174+
export default createBuilder<ProtractorBuilderOptions>(execute);

packages/angular_devkit/build_angular/src/builders/server/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ export function execute(
141141
);
142142
}
143143

144-
export default createBuilder<json.JsonObject & ServerBuilderOptions, ServerBuilderOutput>(execute);
144+
export default createBuilder<ServerBuilderOptions, ServerBuilderOutput>(execute);
145145

146146
async function initialize(
147147
options: ServerBuilderOptions,

0 commit comments

Comments
 (0)