test: update NPM to latest version

This update upgrades the NPM version used for running end-to-end tests to the latest version.

Notable changes include:
- The `NPM_CONFIG__AUTH` configuration, which is tested here, no longer works for local packages as per [npm/cli#3985](npm/cli#3985).
- NPM no longer supports unscoped auth. The configuration error "Invalid auth configuration found: `_auth` must be renamed to `//localhost:39521/:_auth` in the project config" will be encountered.

Author: alan-agius4

tests/legacy-cli/e2e/setup/100-global-cli.ts

@@ -3,7 +3,7 @@ import { getActivePackageManager } from '../utils/packages';
 import { globalNpm } from '../utils/process';
 
 const PACKAGE_MANAGER_VERSION = {
-  'npm': '7.24.0', // TODO: update to latest and fix tests.
+  'npm': '10.8.1',
   'yarn': '1.22.22',
   'pnpm': '9.3.0',
   'bun': '1.1.13',

tests/legacy-cli/e2e/tests/commands/add/npm-env-vars.ts

@@ -1,22 +1,25 @@
 import { expectFileNotToExist, expectFileToExist } from '../../../utils/fs';
-import { installWorkspacePackages } from '../../../utils/packages';
+import { getActivePackageManager, installWorkspacePackages } from '../../../utils/packages';
 import { git, ng } from '../../../utils/process';
 import { createNpmConfigForAuthentication } from '../../../utils/registry';
 import { expectToFail } from '../../../utils/utils';
 
 export default async function () {
   // The environment variable has priority over the .npmrc
   delete process.env['NPM_CONFIG_REGISTRY'];
+  const isNpm = getActivePackageManager() === 'npm';
 
   const command = ['add', '@angular/pwa', '--skip-confirmation'];
   await expectFileNotToExist('public/manifest.webmanifest');
 
   // Works with unscoped registry authentication details
-  await createNpmConfigForAuthentication(false);
-  await ng(...command);
-  await expectFileToExist('public/manifest.webmanifest');
-  await git('clean', '-dxf');
-
+  if (!isNpm) {
+    // NPM no longer support unscoped.
+    await createNpmConfigForAuthentication(false);
+    await ng(...command);
+    await expectFileToExist('public/manifest.webmanifest');
+    await git('clean', '-dxf');
+  }
   // Works with scoped registry authentication details
   await expectFileNotToExist('public/manifest.webmanifest');
 
@@ -25,8 +28,11 @@ export default async function () {
   await expectFileToExist('public/manifest.webmanifest');
 
   // Invalid authentication token
-  await createNpmConfigForAuthentication(false, true);
-  await expectToFail(() => ng(...command));
+  if (isNpm) {
+    // NPM no longer support unscoped.
+    await createNpmConfigForAuthentication(false, true);
+    await expectToFail(() => ng(...command));
+  }
 
   await createNpmConfigForAuthentication(true, true);
   await expectToFail(() => ng(...command));

tests/legacy-cli/e2e/tests/commands/add/secure-registry.ts

@@ -1,8 +1,10 @@
+import { join } from 'node:path';
 import { expectFileToMatch } from '../../utils/fs';
 import { execWithEnv, extractNpmEnv, ng, silentNpm } from '../../utils/process';
 import { getActivePackageManager, installPackage, uninstallPackage } from '../../utils/packages';
 import { isPrereleaseCli } from '../../utils/project';
-import { appendFile } from 'node:fs/promises';
+import { appendFile, writeFile } from 'node:fs/promises';
+import { getGlobalVariable } from '../../utils/env';
 
 export default async function () {
   // Must publish old version to local registry to allow install. This is especially important
@@ -29,15 +31,23 @@ export default async function () {
 }
 
 async function publishOutdated(npmSpecifier: string): Promise<void> {
+  const npmrc = join(getGlobalVariable('tmp-root'), '.npmrc-publish');
+  const testRegistry = (getGlobalVariable('package-registry') as string).replace(/^\w+:/, '');
+  await writeFile(
+    npmrc,
+    `
+    ${testRegistry.replace(/^https?:/, '')}/:_authToken=fake-secret
+    `,
+  );
+
   const { stdout: stdoutPack } = await silentNpm(
     'pack',
     npmSpecifier,
     '--registry=https://registry.npmjs.org',
   );
+
   await execWithEnv('npm', ['publish', stdoutPack.trim(), '--tag=outdated'], {
     ...extractNpmEnv(),
-    // Also set an auth token value for the local test registry which is required by npm 7+
-    // even though it is never actually used.
-    'NPM_CONFIG__AUTH': 'e2e-testing',
+    'NPM_CONFIG_USERCONFIG': npmrc,
   });
 }