refactor(@angular-devkit/schematics): adjust types to support strict mode

Author: clydin

packages/angular_devkit/schematics/src/engine/schematic.ts

@@ -56,9 +56,9 @@ export class SchematicImpl<CollectionT extends object, SchematicT extends object
       .pipe(
         first(),
         concatMap(tree => this._engine.transformOptions(this, options, context).pipe(
-          map(o => [tree, o]),
+          map(o => [tree, o] as [Tree, OptionT]),
         )),
-        concatMap(([tree, transformedOptions]: [Tree, OptionT]) => {
+        concatMap(([tree, transformedOptions]) => {
           let input: Tree;
           let scoped = false;
           if (executionOptions && executionOptions.scope) {

packages/angular_devkit/schematics/src/rules/base.ts

@@ -34,10 +34,7 @@ export function empty(): Source {
  */
 export function chain(rules: Rule[]): Rule {
   return (tree, context) => {
-    return rules.reduce(
-      (acc: Tree | Observable<Tree>, curr: Rule) => callRule(curr, acc, context),
-      tree,
-    );
+    return rules.reduce<Tree | Observable<Tree>>((acc, curr) => callRule(curr, acc, context), tree);
   };
 }
 

packages/angular_devkit/schematics/tasks/node/index.ts

@@ -5,7 +5,7 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import { TaskExecutorFactory } from '../../src';
+import { TaskExecutor, TaskExecutorFactory } from '../../src';
 import { NodePackageName, NodePackageTaskFactoryOptions } from '../package-manager/options';
 import {
   RepositoryInitializerName,
@@ -17,7 +17,7 @@ import { TslintFixName } from '../tslint-fix/options';
 export class BuiltinTaskExecutor {
   static readonly NodePackage: TaskExecutorFactory<NodePackageTaskFactoryOptions> = {
     name: NodePackageName,
-    create: (options) => import('../package-manager/executor').then(mod => mod.default(options)),
+    create: (options) => import('../package-manager/executor').then(mod => mod.default(options)) as Promise<TaskExecutor<{}>>,
   };
   static readonly RepositoryInitializer:
     TaskExecutorFactory<RepositoryInitializerTaskFactoryOptions> = {
@@ -26,7 +26,7 @@ export class BuiltinTaskExecutor {
   };
   static readonly RunSchematic: TaskExecutorFactory<{}> = {
     name: RunSchematicName,
-    create: () => import('../run-schematic/executor').then(mod => mod.default()),
+    create: () => import('../run-schematic/executor').then(mod => mod.default()) as Promise<TaskExecutor<{}>>,
   };
   static readonly TslintFix: TaskExecutorFactory<{}> = {
     name: TslintFixName,

packages/angular_devkit/schematics/tasks/package-manager/install-task.ts

@@ -8,12 +8,13 @@
 import { TaskConfiguration, TaskConfigurationGenerator } from '../../src';
 import { NodePackageName, NodePackageTaskOptions } from './options';
 
+// TODO: This should be an interface but that would change the public API
 export class NodePackageInstallTaskOptions {
-  packageManager: string;
-  packageName: string;
-  workingDirectory: string;
-  quiet: boolean;
-  hideOutput: boolean;
+  packageManager!: string;
+  packageName!: string;
+  workingDirectory!: string;
+  quiet!: boolean;
+  hideOutput!: boolean;
 }
 
 export class NodePackageInstallTask implements TaskConfigurationGenerator<NodePackageTaskOptions> {