refactor(@angular-devkit/core): fix strict types in experimental.

Most of the problems here come from return-only generics. A greater redesign of these core types is necessary to properly fix all the typing issues. However, all these types seem to be exported publicly. In the interest of not introducing any breaking changes, most of these fixes were just casting types to `unknown` or replacing generics with the maximally-allowed type (`JsonValue`).

Author: dgp1130

packages/angular_devkit/core/src/experimental/jobs/dispatcher.ts

@@ -53,26 +53,29 @@ export function createDispatcher<
   options: Partial<Readwrite<JobDescription>> = {},
 ): JobDispatcher<A, I, O> {
   let defaultDelegate: JobName | null = null;
-  const conditionalDelegateList: [(args: A) => boolean, JobName][] = [];
+  const conditionalDelegateList: [(args: JsonValue) => boolean, JobName][] = [];
 
-  const job: JobHandler<A, I, O> = Object.assign((argument: A, context: JobHandlerContext) => {
-    const maybeDelegate = conditionalDelegateList.find(([predicate]) => predicate(argument));
-    let delegate: Job<A, I, O> | null = null;
+  const job: JobHandler<JsonValue, JsonValue, JsonValue> = Object.assign(
+      (argument: JsonValue, context: JobHandlerContext) => {
+        const maybeDelegate = conditionalDelegateList.find(([predicate]) => predicate(argument));
+        let delegate: Job<JsonValue, JsonValue, JsonValue> | null = null;
 
-    if (maybeDelegate) {
-      delegate = context.scheduler.schedule(maybeDelegate[1], argument);
-    } else if (defaultDelegate) {
-      delegate = context.scheduler.schedule(defaultDelegate, argument);
-    } else {
-      throw new JobDoesNotExistException('<null>');
-    }
+        if (maybeDelegate) {
+          delegate = context.scheduler.schedule(maybeDelegate[1], argument);
+        } else if (defaultDelegate) {
+          delegate = context.scheduler.schedule(defaultDelegate, argument);
+        } else {
+          throw new JobDoesNotExistException('<null>');
+        }
 
-    context.inboundBus.subscribe(delegate.inboundBus);
+        context.inboundBus.subscribe(delegate.inboundBus);
 
-    return delegate.outboundBus;
-  }, {
-    jobDescription: options,
-  });
+        return delegate.outboundBus;
+      },
+      {
+        jobDescription: options,
+      },
+  );
 
   return Object.assign(job, {
     setDefaultJob(name: JobName | null | JobHandler<JsonValue, JsonValue, JsonValue>) {
@@ -82,8 +85,9 @@ export function createDispatcher<
 
       defaultDelegate = name;
     },
-    addConditionalJob(predicate: (args: A) => boolean, name: JobName) {
+    addConditionalJob(predicate: (args: JsonValue) => boolean, name: JobName) {
       conditionalDelegateList.push([predicate, name]);
     },
-  });
+  // TODO: Remove return-only generic from createDispatcher() API.
+  }) as unknown as JobDispatcher<A, I, O>;
 }

packages/angular_devkit/core/src/experimental/jobs/dispatcher_spec.ts

@@ -5,6 +5,8 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+import { JsonValue } from '../../json';
+import { JobHandler } from './api';
 import { createJobHandler } from './create-job-handler';
 import { createDispatcher } from './dispatcher';
 import { SimpleJobRegistry } from './simple-registry';
@@ -31,7 +33,7 @@ describe('createDispatcher', () => {
     registry.register(add0);
     registry.register(add100);
 
-    dispatcher.setDefaultJob(add0);
+    dispatcher.setDefaultJob(add0 as JobHandler<JsonValue, JsonValue, number>);
     const sum = scheduler.schedule('add', [1, 2, 3, 4]);
     expect(await sum.output.toPromise()).toBe(10);
   });

packages/angular_devkit/core/src/experimental/jobs/simple-registry.ts

@@ -34,7 +34,7 @@ export class SimpleJobRegistry<
     I extends MinimumInputValueT = MinimumInputValueT,
     O extends MinimumOutputValueT = MinimumOutputValueT,
   >(name: JobName): Observable<JobHandler<A, I, O> | null> {
-    return of(this._jobNames.get(name) as (JobHandler<A, I, O> | null) || null);
+    return of(this._jobNames.get(name) as unknown as (JobHandler<A, I, O> | null) || null);
   }
 
   /**
@@ -132,7 +132,9 @@ export class SimpleJobRegistry<
       input,
     };
 
-    this._jobNames.set(name, Object.assign(handler.bind(undefined), { jobDescription }));
+    const jobHandler = Object.assign(handler.bind(undefined), { jobDescription }) as
+        unknown as JobHandler<MinimumArgumentValueT, MinimumInputValueT, MinimumOutputValueT>;
+    this._jobNames.set(name, jobHandler);
   }
 
   /**

packages/angular_devkit/core/src/experimental/jobs/simple-scheduler.ts

@@ -162,7 +162,7 @@ export class SimpleScheduler<
           argumentV: this._schemaRegistry.compile(description.argument).pipe(shareReplay(1)),
           inputV: this._schemaRegistry.compile(description.input).pipe(shareReplay(1)),
           outputV: this._schemaRegistry.compile(description.output).pipe(shareReplay(1)),
-        });
+        }) as JobHandlerWithExtra;
         this._internalJobDescriptionMap.set(name, handlerWithExtra);
 
         return of(handlerWithExtra);
@@ -419,7 +419,7 @@ export class SimpleScheduler<
 
     const output = outboundBus.pipe(
       filter(x => x.kind == JobOutboundMessageKind.Output),
-      map((x: JobOutboundMessageOutput<O>) => x.value),
+      map((x) => (x as JobOutboundMessageOutput<O>).value),
       shareReplay(1),
     );
 
@@ -444,7 +444,7 @@ export class SimpleScheduler<
         let maybeObservable = channels.get(name);
         if (!maybeObservable) {
           const s = new Subject<T>();
-          channelsSubject.set(name, s);
+          channelsSubject.set(name, s as unknown as Subject<JsonValue>);
           channels.set(name, s.asObservable());
 
           maybeObservable = s.asObservable();
@@ -535,7 +535,7 @@ export class SimpleScheduler<
 
               return handler(argument, context);
             }),
-          ).subscribe(subscriber);
+          ).subscribe(subscriber as Observer<JobOutboundMessage<JsonValue>>);
         })),
       ),
     );

packages/angular_devkit/core/src/experimental/jobs/strategy_spec.ts

@@ -33,7 +33,8 @@ describe('strategy.serialize()', () => {
           resolve(input.reduce((a, c) => a + c, 0));
         }, 10),
       );
-    })), {
+      // tslint:disable-next-line:no-any
+    }) as any), {
       argument: { items: { type: 'number' } },
       output: { type: 'number' },
       name: 'add',
@@ -82,7 +83,8 @@ describe('strategy.serialize()', () => {
           resolve(input.reduce((a, c) => a + c, 0));
         }, 10),
       );
-    })), {
+      // tslint:disable-next-line:no-any
+    }) as any), {
       argument: { items: { type: 'number' } },
       output: { type: 'number' },
       name: 'add',
@@ -96,7 +98,8 @@ describe('strategy.serialize()', () => {
           resolve(input.reduce((a, c) => a + c, 100));
         }, 10),
       );
-    })), {
+      // tslint:disable-next-line:no-any
+    }) as any), {
       argument: { items: { type: 'number' } },
       output: { type: 'number' },
       name: 'add100',
@@ -153,7 +156,8 @@ describe('strategy.reuse()', () => {
           resolve(input.reduce((a, c) => a + c, 0));
         }, 10),
       );
-    })), {
+      // tslint:disable-next-line:no-any
+    }) as any), {
       argument: { items: { type: 'number' } },
       output: { type: 'number' },
       name: 'add',
@@ -220,7 +224,8 @@ describe('strategy.memoize()', () => {
           resolve(input.reduce((a, c) => a + c, 0));
         }, 10),
       );
-    })), {
+      // tslint:disable-next-line:no-any
+    }) as any), {
       argument: { items: { type: 'number' } },
       output: { type: 'number' },
       name: 'add',

packages/angular_devkit/core/src/experimental/workspace/workspace.ts

@@ -90,8 +90,8 @@ export class Workspace {
   ];
 
   private readonly _workspaceSchemaPath = normalize(require.resolve('./workspace-schema.json'));
-  private _workspaceSchema: JsonObject;
-  private _workspace: WorkspaceSchema;
+  private _workspaceSchema?: JsonObject;
+  private _workspace!: WorkspaceSchema;
   private _registry: schema.CoreSchemaRegistry;
 
   constructor(
@@ -129,7 +129,7 @@ export class Workspace {
 
   loadWorkspaceFromJson(json: {}) {
     return this._loadWorkspaceSchema().pipe(
-      concatMap((workspaceSchema) => this.validateAgainstSchema(json, workspaceSchema)),
+      concatMap((workspaceSchema) => this.validateAgainstSchema<WorkspaceSchema>(json, workspaceSchema)),
       tap((validatedWorkspace: WorkspaceSchema) => this._workspace = validatedWorkspace),
       map(() => this),
     );