Skip to content

Commit 481da20

Browse files
dgp1130alan-agius4
authored andcommitted
ci: set CHROME_PATH environment variable to Bazel's Chrome install
This variable is used by Chrome launcher under Web Test Runner to find and execute Chrome. (cherry picked from commit 7bf4dd6)
1 parent 8c81571 commit 481da20

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

tests/legacy-cli/e2e.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ def _e2e_tests(name, runner, **kwargs):
103103
# Chromium browser toolchain
104104
env.update({
105105
"CHROME_BIN": "$(CHROMIUM)",
106+
"CHROME_PATH": "$(CHROMIUM)",
106107
"CHROMEDRIVER_BIN": "$(CHROMEDRIVER)",
107108
})
108109
toolchains = toolchains + ["@npm//@angular/build-tooling/bazel/browsers/chromium:toolchain_alias"]

tests/legacy-cli/e2e/utils/process.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ function extractCIEnv(): NodeJS.ProcessEnv {
177177
v === 'CI' ||
178178
v === 'CIRCLECI' ||
179179
v === 'CHROME_BIN' ||
180+
v === 'CHROME_PATH' ||
180181
v === 'CHROMEDRIVER_BIN',
181182
)
182183
.reduce<NodeJS.ProcessEnv>((vars, n) => {

tests/legacy-cli/e2e_runner.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ setGlobalVariable('package-manager', argv.yarn ? 'yarn' : 'npm');
206206
// Resolve from relative paths to absolute paths within the bazel runfiles tree
207207
// so subprocesses spawned in a different working directory can still find them.
208208
process.env.CHROME_BIN = path.resolve(process.env.CHROME_BIN!);
209+
process.env.CHROME_PATH = path.resolve(process.env.CHROME_PATH!);
209210
process.env.CHROMEDRIVER_BIN = path.resolve(process.env.CHROMEDRIVER_BIN!);
210211

211212
Promise.all([findFreePort(), findFreePort(), findPackageTars()])

0 commit comments

Comments
 (0)