test(@angular/cli): change tests to reflect prod mode by default changes

Author: alan-agius4

tests/legacy-cli/e2e/setup/500-create-project.ts

@@ -50,8 +50,8 @@ export default async function() {
       // In VE non prod builds are non AOT by default
       await updateJsonFile('angular.json', config => {
         const build = config.projects['test-project'].architect.build;
-        build.options.aot = false;
-        build.configurations.production.aot = true;
+        build.options.aot = true;
+        build.configurations.development.aot = false;
       });
     }
   }

tests/legacy-cli/e2e/tests/basic/aot.ts

@@ -3,7 +3,7 @@ import { expectFileToMatch } from '../../utils/fs';
 import { ng } from '../../utils/process';
 
 export default async function () {
-  await ng('build', '--aot=true');
+  await ng('build', '--aot=true', '--configuration=development');
 
   if (getGlobalVariable('argv')['ve']) {
     await expectFileToMatch('dist/test-project/main.js',

tests/legacy-cli/e2e/tests/basic/build.ts

@@ -4,13 +4,13 @@ import { ng } from '../../utils/process';
 
 export default async function() {
   // Development build
-  await ng('build');
+  await ng('build', '--configuration=development');
   await expectFileToMatch('dist/test-project/index.html', 'main.js');
 
   // Named Development build
-  await ng('build', 'test-project');
-  await ng('build', 'test-project', '--no-progress');
-  await ng('build', '--no-progress', 'test-project');
+  await ng('build', 'test-project', '--configuration=development');
+  await ng('build', '--configuration=development', 'test-project', '--no-progress');
+  await ng('build', '--configuration=development', '--no-progress', 'test-project');
 
   // Enable Differential loading to run both size checks
   await replaceInFile(
@@ -19,7 +19,7 @@ export default async function() {
     'IE 11',
   );
   // Production build
-  const { stderr: stderrProgress, stdout } = await ng('build', '--prod', '--progress');
+  const { stderr: stderrProgress, stdout } = await ng('build', '--progress');
   await expectFileToMatch('dist/test-project/index.html', /main-es5\.[a-zA-Z0-9]{20}\.js/);
   await expectFileToMatch('dist/test-project/index.html', /main-es2015\.[a-zA-Z0-9]{20}\.js/);
 
@@ -44,7 +44,7 @@ export default async function() {
     }
   }
 
-  const { stderr: stderrNoProgress } = await ng('build', '--prod', '--no-progress');
+  const { stderr: stderrNoProgress } = await ng('build', '--no-progress');
   for (const log of logs) {
     if (stderrNoProgress.includes(log)) {
       throw new Error(`Expected stderr not to contain '${log}' but it did.\n${stderrProgress}`);

tests/legacy-cli/e2e/tests/basic/e2e.ts

@@ -12,7 +12,7 @@ export default function () {
     .then(() => expectToFail(() => ng('e2e', 'test-project', '--devServerTarget=')))
     // These should work.
     .then(() => ng('e2e', 'test-project'))
-    .then(() => ng('e2e', 'test-project', '--devServerTarget=test-project:serve:production'))
+    .then(() => ng('e2e', 'test-project', '--devServerTarget=test-project:serve'))
     // Should accept different config file
     .then(() => moveFile('./e2e/protractor.conf.js',
       './e2e/renamed-protractor.conf.js'))

tests/legacy-cli/e2e/tests/basic/environment.ts

@@ -8,6 +8,7 @@ export default async function () {
   await updateJsonFile('angular.json', configJson => {
     const appArchitect = configJson.projects['test-project'].architect;
     appArchitect.build.configurations['prod-env'] = {
+      ...appArchitect.build.configurations['development'],
       fileReplacements: [
         {
           src: 'src/environments/environment.ts',

tests/legacy-cli/e2e/tests/basic/ngcc-es2015-only.ts

@@ -13,7 +13,7 @@ export default async function() {
     // Don't run this test for VE jobs. It only applies to Ivy.
     return;
   }
-  const { stderr, stdout } = await ng('build', '--prod');
+  const { stderr, stdout } = await ng('build');
 
   if (stdout.includes('as esm5') || stderr.includes('as esm5')) {
     throw new Error('ngcc should not process ES5 during differential loading builds.');

tests/legacy-cli/e2e/tests/basic/scripts-array.ts

@@ -41,7 +41,7 @@ export default async function () {
     ];
   });
 
-  await ng('build', '--extract-css');
+  await ng('build', '--extract-css', '--configuration=development');
 
   // files were created successfully
   await expectFileToMatch('dist/test-project/scripts.js', 'string-script');

tests/legacy-cli/e2e/tests/basic/size-tracking.ts

@@ -31,7 +31,7 @@ export default async function () {
     await ng('generate', 'module', 'lazy', '--route=lazy', '--module=app.module');
 
     // Build without hashing and with named chunks to keep have consistent file names.
-    await ng('build', '--prod', '--output-hashing=none', '--named-chunks=true');
+    await ng('build', '--output-hashing=none', '--named-chunks=true');
 
     // Upload to the store_artifacts dir listed in .circleci/config.yml
     await moveDirectory('dist', '/tmp/dist');

tests/legacy-cli/e2e/tests/basic/styles-array.ts

@@ -27,7 +27,7 @@ export default async function() {
     ];
   });
 
-  await ng('build', '--extract-css');
+  await ng('build', '--extract-css', '--configuration=development');
 
   await expectFileToMatch('dist/test-project/styles.css', '.string-style');
   await expectFileToMatch('dist/test-project/styles.css', '.input-style');

tests/legacy-cli/e2e/tests/build/allow-js.ts

@@ -15,6 +15,6 @@ export default async function() {
     json['compilerOptions'].allowJs = true;
   });
 
-  await ng('build');
-  await ng('build', '--aot');
+  await ng('build', '--configuration=development');
+  await ng('build', '--aot', '--configuration=development');
 }