build: migrate @angular/pwa tests to rules_js

This commit changes the execution of `@angular/pwa` tests to `rules_js`
native `jasmine_test`.

This requires setting it up in the pnpm workspace for first-party linked
dependencies, and it also requires a small trick for making the peer
dependency substitution work well with the pnpm workspace installs. pnpm
will fail as it couldn't find a "suitable" local, or external version,
so we are just using the local variant for install, and later replace
during "packaging" via an extra substitution.

Ideally we'd somehow leave the placeholder for clarity, but it's not
possible right now. Good thing is that the peer deps aren't being
touched here, as it's all done via constants now.

Author: devversion

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -4,11 +4,12 @@
 .npmrc=-2023857461
 package.json=-497647638
 packages/angular/cli/package.json=-1878910022
+packages/angular/pwa/package.json=-466738595
 packages/angular_devkit/architect/package.json=-1496633956
 packages/angular_devkit/architect_cli/package.json=1551210941
 packages/angular_devkit/core/package.json=339935828
 packages/angular_devkit/schematics/package.json=673943597
 packages/schematics/angular/package.json=251715148
-pnpm-lock.yaml=1517985739
-pnpm-workspace.yaml=-1051214858
+pnpm-lock.yaml=1107856419
+pnpm-workspace.yaml=-818108966
 yarn.lock=-1008526801

WORKSPACE

@@ -187,6 +187,7 @@ npm_translate_lock(
         "//:package.json",
         "//:pnpm-workspace.yaml",
         "//packages/angular/cli:package.json",
+        "//packages/angular/pwa:package.json",
         "//packages/angular_devkit/architect:package.json",
         "//packages/angular_devkit/architect_cli:package.json",
         "//packages/angular_devkit/core:package.json",

packages/angular/pwa/BUILD.bazel

@@ -3,14 +3,17 @@
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.dev/license
 
-load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test")
-load("//tools:defaults2.bzl", "npm_package", "ts_project")
+load("@npm2//:defs.bzl", "npm_link_all_packages")
+load("//:constants.bzl", "ANGULAR_FW_PEER_DEP")
+load("//tools:defaults2.bzl", "jasmine_test", "npm_package", "ts_project")
 load("//tools:ts_json_schema.bzl", "ts_json_schema")
 
 licenses(["notice"])
 
 package(default_visibility = ["//visibility:public"])
 
+npm_link_all_packages()
+
 RUNTIME_ASSETS = glob(
     include = [
         "pwa/*.js",
@@ -32,10 +35,10 @@ ts_project(
     data = RUNTIME_ASSETS,
     module_name = "@angular/pwa",
     deps = [
+        ":node_modules/@angular-devkit/schematics",
+        ":node_modules/@schematics/angular",
         "//:node_modules/@types/node",
         "//:node_modules/parse5-html-rewriting-stream",
-        "//packages/angular_devkit/schematics:schematics_rjs",
-        "//packages/schematics/angular:angular_rjs",
     ],
 )
 
@@ -55,9 +58,9 @@ ts_project(
     ],
 )
 
-jasmine_node_test(
+jasmine_test(
     name = "pwa_test",
-    srcs = [":pwa_test_lib"],
+    data = [":pwa_test_lib_rjs"],
 )
 
 genrule(
@@ -69,6 +72,10 @@ genrule(
 
 npm_package(
     name = "pkg",
+    extra_substitutions = {
+        # Peer dependency is replaced as pnpm workspace otherwise can't resolve it.
+        "\"../cli\"": "\"%s\"" % ANGULAR_FW_PEER_DEP,
+    },
     pkg_deps = [
         "//packages/angular_devkit/schematics:package.json",
         "//packages/schematics/angular:package.json",

packages/angular/pwa/package.json

@@ -12,12 +12,12 @@
     "save": false
   },
   "dependencies": {
-    "@angular-devkit/schematics": "0.0.0-PLACEHOLDER",
-    "@schematics/angular": "0.0.0-PLACEHOLDER",
+    "@angular-devkit/schematics": "workspace:0.0.0-PLACEHOLDER",
+    "@schematics/angular": "workspace:0.0.0-PLACEHOLDER",
     "parse5-html-rewriting-stream": "7.0.0"
   },
   "peerDependencies": {
-    "@angular/cli": "0.0.0-ANGULAR-FW-PEER-DEP"
+    "@angular/cli": "../cli"
   },
   "peerDependenciesMeta": {
     "@angular/cli": {

pnpm-lock.yaml

@@ -5,4 +5,5 @@ packages:
   - packages/angular_devkit/core
   - packages/angular_devkit/schematics
   - packages/angular/cli
+  - packages/angular/pwa
   - packages/schematics/angular

pnpm-workspace.yaml

@@ -15,6 +15,7 @@ def npm_package(
         pkg_deps = [],
         stamp_files = [],
         pkg_json = "package.json",
+        extra_substitutions = {},
         **kwargs):
     if name != "pkg":
         fail("Expected npm_package to be named `pkg`. " +
@@ -61,6 +62,9 @@ def npm_package(
         out = "substituted_with_snapshot_repos/package.json",
     )
 
+    nostamp_subs = dict(substitutions["rjs"]["nostamp"], **extra_substitutions)
+    stamp_subs = dict(substitutions["rjs"]["stamp"], **extra_substitutions)
+
     expand_template(
         name = "final_package_json",
         template = select({
@@ -71,8 +75,8 @@ def npm_package(
             "//conditions:default": "substituted/package.json",
         }),
         out = "substituted_final/package.json",
-        substitutions = substitutions["rjs"]["nostamp"],
-        stamp_substitutions = substitutions["rjs"]["stamp"],
+        substitutions = nostamp_subs,
+        stamp_substitutions = stamp_subs,
     )
 
     stamp_targets = []
@@ -81,8 +85,8 @@ def npm_package(
             name = "stamp_file_%s" % f,
             template = f,
             out = "substituted/%s" % f,
-            substitutions = substitutions["rjs"]["nostamp"],
-            stamp_substitutions = substitutions["rjs"]["stamp"],
+            substitutions = nostamp_subs,
+            stamp_substitutions = stamp_subs,
         )
 
         stamp_targets.append("stamp_file_%s" % f)