test: remove disableTypeScriptVersionCheck from tests setup

This option causes our CI to be green even when new projects are created with mismatching TypeScript versions, which causes failures in a real-world project.

See #22333 for more context.

(cherry picked from commit fb3b1fe)

Author: alan-agius4

tests/legacy-cli/e2e/setup/500-create-project.ts

@@ -6,7 +6,7 @@ import { setRegistry as setNPMConfigRegistry } from '../utils/packages';
 import { ng, npm } from '../utils/process';
 import { prepareProjectForE2e, updateJsonFile } from '../utils/project';
 
-export default async function() {
+export default async function () {
   const argv = getGlobalVariable('argv');
 
   if (argv.noproject) {
@@ -28,15 +28,6 @@ export default async function() {
     await expectFileToExist(join(process.cwd(), 'test-project'));
     process.chdir('./test-project');
 
-    // Disable the TS version check to make TS updates easier.
-    // Only VE does it, but on Ivy the i18n extraction uses VE.
-    await updateJsonFile('tsconfig.json', config => {
-      if (!config.angularCompilerOptions) {
-        config.angularCompilerOptions = {};
-      }
-      config.angularCompilerOptions.disableTypeScriptVersionCheck = true;
-    });
-
     // If on CI, the user configuration set above will handle project usage
     if (!isCI) {
       // Ensure local test registry is used inside a project

tests/legacy-cli/e2e/tests/i18n/ivy-localize-es2015.ts

@@ -4,18 +4,14 @@ import { updateJsonFile } from '../../utils/project';
 import { expectToFail } from '../../utils/utils';
 import { externalServer, langTranslations, setupI18nConfig } from './setup';
 
-export default async function() {
+export default async function () {
   // Setup i18n tests and config.
   await setupI18nConfig();
 
   // Ensure a es2017 build is used.
   await writeFile('.browserslistrc', 'Chrome 65');
-  await updateJsonFile('tsconfig.json', config => {
+  await updateJsonFile('tsconfig.json', (config) => {
     config.compilerOptions.target = 'es2017';
-    if (!config.angularCompilerOptions) {
-      config.angularCompilerOptions = {};
-    }
-    config.angularCompilerOptions.disableTypeScriptVersionCheck = true;
   });
 
   await ng('build', '--source-map');