Skip to content

Commit 67f8312

Browse files
committed
test: reduce flakiness in serve-live-reload-proxies test
Attempts to stabilize the flaky serve-live-reload-proxies test. This change passed 10 consecutive local runs without failure.
1 parent 199c12c commit 67f8312

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

packages/angular_devkit/build_angular/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,14 @@ async function goToPageAndWaitForWS(page: Page, url: string): Promise<void> {
135135
]);
136136

137137
await client.detach();
138+
139+
// Workaround for:
140+
// Stack:
141+
// error properties: Object({ errno: -104, code: 'ECONNRESET', syscall: 'read' })
142+
// at TCP.onStreamRead (node:internal/stream_base_commons:216:20)
143+
// Message:
144+
// Expected 'app' to be 'app-live-reload'.
145+
await setTimeoutPromise(500);
138146
}
139147

140148
describeServeBuilder(
@@ -205,9 +213,6 @@ describeServeBuilder(
205213
async ({ result }) => {
206214
expect(result?.success).toBeTrue();
207215

208-
// Wait for page to reload.
209-
await setTimeoutPromise(500);
210-
211216
const innerText = await page.evaluate(() => document.querySelector('p').innerText);
212217
expect(innerText).toBe('app-live-reload');
213218
},
@@ -240,9 +245,6 @@ describeServeBuilder(
240245
async ({ result }) => {
241246
expect(result?.success).toBeTrue();
242247

243-
// Wait for page to reload.
244-
await setTimeoutPromise(500);
245-
246248
const innerText = await page.evaluate(
247249
() => document.querySelector('p').innerText,
248250
);
@@ -283,9 +285,6 @@ describeServeBuilder(
283285
async ({ result }) => {
284286
expect(result?.success).toBeTrue();
285287

286-
// Wait for page to reload.
287-
await setTimeoutPromise(500);
288-
289288
const innerText = await page.evaluate(
290289
() => document.querySelector('p').innerText,
291290
);

0 commit comments

Comments
 (0)