Skip to content

Commit 7389fb0

Browse files
committed
fix(@angular/build): ensure matching coverage excludes with karma on Windows
1 parent c39c344 commit 7389fb0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ jobs:
141141
- name: Setup Bazel RBE
142142
uses: angular/dev-infra/github-actions/bazel/configure-remote@836bdd0543d15904c469f5a0ce869d30a8029971
143143
- name: Run CLI E2E tests
144-
run: yarn bazel test --config=e2e //tests/legacy-cli:e2e_node22 --test_filter="tests/basic/{build,rebuild}.ts" --test_arg="--esbuild"
144+
run: yarn bazel test --config=e2e //tests/legacy-cli:e2e_node22 --test_filter="tests/basic/{build,rebuild}.ts,tests/test/test-code-coverage-exclude.ts" --test_arg="--esbuild"
145145

146146
e2e-package-managers:
147147
needs: build

packages/angular/build/src/builders/karma/application_builder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ function getInstrumentationExcludedPaths(root: string, excludedPaths: string[]):
614614

615615
for (const excludeGlob of excludedPaths) {
616616
const excludePath = excludeGlob[0] === '/' ? excludeGlob.slice(1) : excludeGlob;
617-
globSync(excludePath, { absolute: true, cwd: root }).forEach((p) => excluded.add(p));
617+
globSync(excludePath, { cwd: root }).forEach((p) => excluded.add(path.join(root, p)));
618618
}
619619

620620
return excluded;

0 commit comments

Comments
 (0)