Skip to content

Commit 74cf3a0

Browse files
clydinfilipesilva
authored andcommitted
build: remove unneeded node/yarn_repositories bazel option
The `node_repositories` and `yarn_repositories` options for the `node_repositories` rule are optional and will contain all known public versions if not specified.
1 parent e0c3f85 commit 74cf3a0

File tree

1 file changed

+1
-21
lines changed

1 file changed

+1
-21
lines changed

WORKSPACE

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -27,32 +27,12 @@ Try running `yarn bazel` instead.
2727
minimum_bazel_version = "4.0.0",
2828
)
2929

30-
# The NodeJS rules version must be at least the following version because:
31-
# - 0.15.2 Re-introduced the prod_only attribute on yarn_install
32-
# - 0.15.3 Includes a fix for the `jasmine_node_test` rule ignoring target tags
33-
# - 0.16.8 Supports npm installed bazel workspaces
34-
# - 0.26.0 Fix for data files in yarn_install and npm_install
35-
# - 0.27.12 Adds NodeModuleSources provider for transtive npm deps support
36-
# - 0.30.0 yarn_install now uses symlinked node_modules with new managed directories Bazel 0.26.0 feature
37-
# - 0.31.1 entry_point attribute of nodejs_binary & rollup_bundle is now a label
38-
# - 0.32.0 yarn_install and npm_install no longer puts build files under symlinked node_modules
39-
# - 0.32.1 remove override of @bazel/tsetse & exclude typescript lib declarations in node_module_library transitive_declarations
40-
# - 0.32.2 resolves bug in @bazel/hide-bazel-files postinstall step
41-
# - 0.34.0 introduces protractor rule
4230
check_rules_nodejs_version(minimum_version_string = "2.0.0")
4331

4432
# Setup the Node.js toolchain
4533
node_repositories(
46-
node_repositories = {
47-
"12.14.1-darwin_amd64": ("node-v12.14.1-darwin-x64.tar.gz", "node-v12.14.1-darwin-x64", "0be10a28737527a1e5e3784d3ad844d742fe8b0718acd701fd48f718fd3af78f"),
48-
"12.14.1-linux_amd64": ("node-v12.14.1-linux-x64.tar.xz", "node-v12.14.1-linux-x64", "07cfcaa0aa9d0fcb6e99725408d9e0b07be03b844701588e3ab5dbc395b98e1b"),
49-
"12.14.1-windows_amd64": ("node-v12.14.1-win-x64.zip", "node-v12.14.1-win-x64", "1f96ccce3ba045ecea3f458e189500adb90b8bc1a34de5d82fc10a5bf66ce7e3"),
50-
},
51-
node_version = "12.14.1",
5234
package_json = ["//:package.json"],
53-
yarn_repositories = {
54-
"1.22.4": ("yarn-v1.22.4.tar.gz", "yarn-v1.22.4", "bc5316aa110b2f564a71a3d6e235be55b98714660870c5b6b2d2d3f12587fb58"),
55-
},
35+
node_version = "12.14.1",
5636
yarn_version = "1.22.4",
5737
)
5838

0 commit comments

Comments
 (0)