Skip to content

Commit 7a6cb21

Browse files
committed
Revert "feat(@angular/cli): adding skip e2e test option"
This reverts commit fdea2df.
1 parent b0db305 commit 7a6cb21

File tree

5 files changed

+16
-40
lines changed

5 files changed

+16
-40
lines changed

docs/documentation/new.md

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Default applications are created in a directory of the same name, with an initia
1111
<details>
1212
<summary>directory</summary>
1313
<p>
14-
<code>--directory</code> (aliases: <code>-dir</code>) <em>default value: dir</em>
14+
`--directory` (alias: `-dir`) _default value: dir_
1515
</p>
1616
<p>
1717
The directory name to create the app in.
@@ -21,7 +21,7 @@ Default applications are created in a directory of the same name, with an initia
2121
<details>
2222
<summary>dry-run</summary>
2323
<p>
24-
<code>--dry-run</code> (aliases: <code>-d</code>) <em>default value: false</em>
24+
`--dry-run` (alias: `-d`) _default value: false_
2525
</p>
2626
<p>
2727
Run through without making any changes.
@@ -31,7 +31,7 @@ Default applications are created in a directory of the same name, with an initia
3131
<details>
3232
<summary>inline-style</summary>
3333
<p>
34-
<code>--inline-style</code> (aliases: <code>-is</code>) <em>default value: false</em>
34+
`--inline-style` (alias: `-is`) _default value: false_
3535
</p>
3636
<p>
3737
Should have an inline style.
@@ -41,7 +41,7 @@ Default applications are created in a directory of the same name, with an initia
4141
<details>
4242
<summary>inline-template</summary>
4343
<p>
44-
<code>--inline-template</code> (aliases: <code>-it</code>) <em>default value: false</em>
44+
`--inline-template` (alias: `-it`) _default value: false_
4545
</p>
4646
<p>
4747
Should have an inline template.
@@ -51,7 +51,7 @@ Default applications are created in a directory of the same name, with an initia
5151
<details>
5252
<summary>prefix</summary>
5353
<p>
54-
<code>--prefix</code> (aliases: <code>-p</code>) <em>default value: app</em>
54+
`--prefix` (alias: `-p`) _default value: app_
5555
</p>
5656
<p>
5757
The prefix to use for all component selectors.
@@ -61,7 +61,7 @@ Default applications are created in a directory of the same name, with an initia
6161
<details>
6262
<summary>routing</summary>
6363
<p>
64-
<code>--routing</code> <em>default value: false</em>
64+
`--routing` _default value: false_
6565
</p>
6666
<p>
6767
Generate a routing module.
@@ -71,7 +71,7 @@ Default applications are created in a directory of the same name, with an initia
7171
<details>
7272
<summary>skip-commit</summary>
7373
<p>
74-
<code>--skip-commit</code> (aliases: <code>-sc</code>) <em>default value: false</em>
74+
`--skip-commit` (alias: `-sc`) _default value: false_
7575
</p>
7676
<p>
7777
Skip committing the first commit to git.
@@ -81,7 +81,7 @@ Default applications are created in a directory of the same name, with an initia
8181
<details>
8282
<summary>skip-git</summary>
8383
<p>
84-
<code>--skip-git</code> (aliases: <code>-sg</code>) <em>default value: false</em>
84+
`--skip-git` (alias: `-sg`) _default value: false_
8585
</p>
8686
<p>
8787
Skip initializing a git repository.
@@ -91,7 +91,7 @@ Default applications are created in a directory of the same name, with an initia
9191
<details>
9292
<summary>skip-install</summary>
9393
<p>
94-
<code>--skip-install</code> (aliases: <code>-si</code>) <em>default value: false</em>
94+
`--skip-install` (alias: `-si`) _default value: false_
9595
</p>
9696
<p>
9797
Skip installing packages.
@@ -106,13 +106,6 @@ Default applications are created in a directory of the same name, with an initia
106106
<p>
107107
Skip creating spec files.
108108
</p>
109-
</details>
110-
111-
<details>
112-
<summary>skip-e2e</summary>
113-
<p>
114-
<code>--skip-e2e</code> (alias: <code>-se</code>) <em>default value: false</em>
115-
</p>
116109
<p>
117110
Skip including e2e functionality.
118111
</p>
@@ -121,7 +114,7 @@ Default applications are created in a directory of the same name, with an initia
121114
<details>
122115
<summary>source-dir</summary>
123116
<p>
124-
<code>--source-dir</code> (aliases: <code>-sd</code>) <em>default value: src</em>
117+
`--source-dir` (alias: `-sd`) _default value: src_
125118
</p>
126119
<p>
127120
The name of the source directory.
@@ -131,7 +124,7 @@ Default applications are created in a directory of the same name, with an initia
131124
<details>
132125
<summary>style</summary>
133126
<p>
134-
<code>--style</code> <em>default value: css</em>
127+
`--style` _default value: css_
135128
</p>
136129
<p>
137130
The style file default extension.
@@ -141,7 +134,7 @@ Default applications are created in a directory of the same name, with an initia
141134
<details>
142135
<summary>verbose</summary>
143136
<p>
144-
<code>--verbose</code> (aliases: <code>-v</code>) <em>default value: false</em>
137+
`--verbose` (alias: `-v`) _default value: false_
145138
</p>
146139
<p>
147140
Adds more details to output logging.

packages/@angular/cli/blueprints/ng/files/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@
3737
"karma-cli": "~1.0.1",
3838
"karma-jasmine": "~1.1.0",
3939
"karma-jasmine-html-reporter": "^0.2.2",
40-
"karma-coverage-istanbul-reporter": "^0.2.0",<% if(e2e) { %>
40+
"karma-coverage-istanbul-reporter": "^0.2.0",
4141
"protractor": "~5.1.0",
42-
"ts-node": "~2.0.0",<% } %>
42+
"ts-node": "~2.0.0",
4343
"tslint": "~4.5.0",
4444
"typescript": "~2.2.0"
4545
}

packages/@angular/cli/blueprints/ng/index.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export default Blueprint.extend({
3535
// set this.tests to opposite of skipTest options,
3636
// meaning if tests are being skipped then the default.spec.BLUEPRINT will be false
3737
this.tests = options.skipTests ? false : true;
38-
this.e2e = options.skipE2e ? false : true;
3938

4039
// Split/join with / not path.sep as reference to typings require forward slashes.
4140
const relativeRootPath = options.sourceDir.split('/').map(() => '..').join('/');
@@ -55,8 +54,7 @@ export default Blueprint.extend({
5554
routing: options.routing,
5655
inlineStyle: options.inlineStyle,
5756
inlineTemplate: options.inlineTemplate,
58-
tests: this.tests,
59-
e2e: this.e2e,
57+
tests: this.tests
6058
};
6159
},
6260

@@ -80,13 +78,6 @@ export default Blueprint.extend({
8078
fileList = fileList.filter(p => p.indexOf('app.component.spec.ts') < 0);
8179
}
8280

83-
if (this.options && this.options.skipE2e) {
84-
fileList = fileList
85-
.filter(p => p.indexOf('protractor.conf.js') < 0)
86-
.filter(p => p.indexOf('app.po.ts') < 0)
87-
.filter(p => p.indexOf('app.e2e-spec.ts') < 0);
88-
}
89-
9081
const cliConfig = CliConfig.fromProject();
9182
const ngConfig = cliConfig && cliConfig.config;
9283
if (!ngConfig || ngConfig.packageManager != 'yarn') {

packages/@angular/cli/commands/new.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,6 @@ const NewCommand = Command.extend({
6262
aliases: ['st'],
6363
description: 'Skip creating spec files.'
6464
},
65-
{
66-
name: 'skip-e2e',
67-
type: Boolean,
68-
default: false,
69-
aliases: ['s2'],
70-
description: 'Skip creating e2e files.'
71-
},
7265
{
7366
name: 'skip-commit',
7467
type: Boolean,

packages/@angular/cli/tasks/init.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ export default Task.extend({
7878
inlineTemplate: commandOptions.inlineTemplate,
7979
ignoredUpdateFiles: ['favicon.ico'],
8080
skipGit: commandOptions.skipGit,
81-
skipTests: commandOptions.skipTests,
82-
skipE2e: commandOptions.skipE2e
81+
skipTests: commandOptions.skipTests
8382
};
8483

8584
validateProjectName(packageName);

0 commit comments

Comments
 (0)