Skip to content

Commit 80f3fb6

Browse files
committed
ci: reorder lint job
Reorder the lint job to allow for license check failures to be the last check
1 parent 4f72ddb commit 80f3fb6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/pr.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ jobs:
5353
run: yarn ts-circular-deps check
5454
- name: Run Validation
5555
run: yarn admin validate
56-
- name: Check Package Licenses
57-
uses: angular/dev-infra/github-actions/linting/licenses@40b2cbdbcc40f36f125d721c4e8decd3bb607ea4
5856
- name: Check tooling setup
5957
run: yarn check-tooling-setup
6058
- name: Check commit message
@@ -65,6 +63,9 @@ jobs:
6563
# Code formatting checks are only done on pull requests as its too late to validate once
6664
# it has been merged.
6765
run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}
66+
# This check is done last as it is the one most often allowed to merge despite failure.
67+
- name: Check Package Licenses
68+
uses: angular/dev-infra/github-actions/linting/licenses@40b2cbdbcc40f36f125d721c4e8decd3bb607ea4
6869

6970
build:
7071
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)