Skip to content

Commit 8775c17

Browse files
Alan Agiusalexeagle
authored andcommitted
test: refactor webpack tests to work and use angular compiler-cli 8
1 parent 8233935 commit 8775c17

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+110
-134
lines changed

tests/legacy-cli/e2e/assets/webpack/test-app-ng5/package.json

Lines changed: 0 additions & 28 deletions
This file was deleted.

tests/legacy-cli/e2e/assets/webpack/test-app-weird-ng5/package.json

Lines changed: 0 additions & 29 deletions
This file was deleted.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import {NgModule, Component} from '@angular/core';
22
import {RouterModule} from '@angular/router';
3-
import {HttpModule, Http} from '@angular/http';
43

54
@Component({
65
selector: 'lazy-feature-comp',
@@ -13,11 +12,8 @@ export class LazyFeatureComponent {}
1312
RouterModule.forChild([
1413
{path: '', component: LazyFeatureComponent, pathMatch: 'full'},
1514
{path: 'feature', loadChildren: './feature.module#FeatureModule'}
16-
]),
17-
HttpModule
15+
])
1816
],
1917
declarations: [LazyFeatureComponent]
2018
})
21-
export class LazyFeatureModule {
22-
constructor(http: Http) {}
23-
}
19+
export class LazyFeatureModule {}

tests/legacy-cli/e2e/assets/webpack/test-server-app-ng5/app/lazy.module.ts renamed to tests/legacy-cli/e2e/assets/webpack/test-app-weird/not/so/source/app/lazy.module.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import {NgModule, Component} from '@angular/core';
22
import {RouterModule} from '@angular/router';
3-
import {HttpModule, Http} from '@angular/http';
43

54
@Component({
65
selector: 'lazy-comp',
@@ -15,12 +14,9 @@ export class LazyComponent {}
1514
{path: 'feature', loadChildren: './feature/feature.module#FeatureModule'},
1615
{path: 'lazy-feature', loadChildren: './feature/lazy-feature.module#LazyFeatureModule'}
1716
]),
18-
HttpModule
1917
],
2018
declarations: [LazyComponent]
2119
})
22-
export class LazyModule {
23-
constructor(http: Http) {}
24-
}
20+
export class LazyModule {}
2521

2622
export class SecondModule {}

0 commit comments

Comments
 (0)