fix(@angular-devkit/build-angular): convert dev-server glob proxy entries for esbuild builder

When using the esbuild-based browser application builder with the development server, an
underlying Vite server is used. The Vite server currently does not support glob-based entries
for the proxy configuration. They must either be prefix strings or regular expressions. The
Webpack-based development server, however, does support globs. To remove the need to have
different proxy configuration files for the two servers, the entries will now be normalized
to regular expressions when using the Vite server. This allows existing proxy configurations
to work without modification.

Author: clydin

package.json

@@ -112,6 +112,7 @@
     "@types/node-fetch": "^2.1.6",
     "@types/npm-package-arg": "^6.1.0",
     "@types/pacote": "^11.1.3",
+    "@types/picomatch": "^2.3.0",
     "@types/pidusage": "^2.0.1",
     "@types/progress": "^2.0.3",
     "@types/resolve": "^1.17.1",
@@ -124,8 +125,8 @@
     "@types/yarnpkg__lockfile": "^1.1.5",
     "@typescript-eslint/eslint-plugin": "5.59.2",
     "@typescript-eslint/parser": "5.59.2",
-    "@yarnpkg/lockfile": "1.1.0",
     "@vitejs/plugin-basic-ssl": "1.0.1",
+    "@yarnpkg/lockfile": "1.1.0",
     "ajv": "8.12.0",
     "ajv-formats": "2.1.1",
     "ansi-colors": "4.1.3",
@@ -181,6 +182,7 @@
     "ora": "5.4.1",
     "pacote": "15.1.3",
     "parse5-html-rewriting-stream": "7.0.0",
+    "picomatch": "2.3.1",
     "pidtree": "^0.6.0",
     "pidusage": "^3.0.0",
     "piscina": "3.2.0",

packages/angular_devkit/build_angular/BUILD.bazel

@@ -136,6 +136,7 @@ ts_library(
         "@npm//@types/less",
         "@npm//@types/loader-utils",
         "@npm//@types/node",
+        "@npm//@types/picomatch",
         "@npm//@types/semver",
         "@npm//@types/text-table",
         "@npm//@vitejs/plugin-basic-ssl",

packages/angular_devkit/build_angular/package.json

@@ -49,6 +49,7 @@
     "open": "8.4.2",
     "ora": "5.4.1",
     "parse5-html-rewriting-stream": "7.0.0",
+    "picomatch": "2.3.1",
     "piscina": "3.2.0",
     "postcss": "8.4.23",
     "postcss-loader": "7.3.0",

packages/angular_devkit/build_angular/src/builders/dev-server/load-proxy-config.ts

@@ -6,10 +6,12 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import { hasMagic as isDynamicPattern } from 'glob';
 import { existsSync } from 'node:fs';
 import { readFile } from 'node:fs/promises';
 import { extname, resolve } from 'node:path';
 import { pathToFileURL } from 'node:url';
+import { parse as parseGlob } from 'picomatch';
 import { assertIsError } from '../../utils/error';
 import { loadEsmModule } from '../../utils/load-esm';
 
@@ -69,6 +71,21 @@ export async function loadProxyConfiguration(root: string, proxyConfig: string |
   }
 }
 
+/**
+ * Converts glob patterns to regular expressions to support Vite's proxy option.
+ * @param proxy A proxy configuration object.
+ */
+export function normalizeProxyConfiguration(proxy: Record<string, unknown>) {
+  // TODO: Consider upstreaming glob support
+  for (const key of Object.keys(proxy)) {
+    if (isDynamicPattern(key)) {
+      const { output } = parseGlob(key);
+      proxy[`^${output}$`] = proxy[key];
+      delete proxy[key];
+    }
+  }
+}
+
 /**
  * Calculates the line and column for an error offset in the content of a JSON file.
  * @param location The offset error location from the beginning of the content.

packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts

@@ -18,7 +18,7 @@ import path from 'node:path';
 import { InlineConfig, ViteDevServer, createServer, normalizePath } from 'vite';
 import { buildEsbuildBrowser } from '../browser-esbuild';
 import type { Schema as BrowserBuilderOptions } from '../browser-esbuild/schema';
-import { loadProxyConfiguration } from './load-proxy-config';
+import { loadProxyConfiguration, normalizeProxyConfiguration } from './load-proxy-config';
 import type { NormalizedDevServerOptions } from './options';
 import type { DevServerBuilderOutput } from './webpack-server';
 
@@ -182,6 +182,9 @@ export async function setupServer(
     serverOptions.workspaceRoot,
     serverOptions.proxyConfig,
   );
+  if (proxy) {
+    normalizeProxyConfiguration(proxy);
+  }
 
   const configuration: InlineConfig = {
     configFile: false,

yarn.lock

@@ -125,7 +125,6 @@
 
 "@angular/build-tooling@https://github.com/angular/dev-infra-private-build-tooling-builds.git#988781b092b543a21af7996f26cda23b43b70226":
   version "0.0.0-e82631b66d14e57672e21ca7d021b8425214771e"
-  uid "988781b092b543a21af7996f26cda23b43b70226"
   resolved "https://github.com/angular/dev-infra-private-build-tooling-builds.git#988781b092b543a21af7996f26cda23b43b70226"
   dependencies:
     "@angular-devkit/build-angular" "16.0.0-rc.4"
@@ -286,7 +285,6 @@
 
 "@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#01d77bf81a01d438b86026aacb9abeee03f53f65":
   version "0.0.0-e82631b66d14e57672e21ca7d021b8425214771e"
-  uid "01d77bf81a01d438b86026aacb9abeee03f53f65"
   resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#01d77bf81a01d438b86026aacb9abeee03f53f65"
   dependencies:
     "@yarnpkg/lockfile" "^1.1.0"
@@ -3367,6 +3365,11 @@
   dependencies:
     parse5 "*"
 
+"@types/picomatch@^2.3.0":
+  version "2.3.0"
+  resolved "https://registry.yarnpkg.com/@types/picomatch/-/picomatch-2.3.0.tgz#75db5e75a713c5a83d5b76780c3da84a82806003"
+  integrity sha512-O397rnSS9iQI4OirieAtsDqvCj4+3eY1J+EPdNTKuHuRWIfUoGyzX294o8C4KJYaLqgSrd2o60c5EqCU8Zv02g==
+
 "@types/pidusage@^2.0.1":
   version "2.0.2"
   resolved "https://registry.yarnpkg.com/@types/pidusage/-/pidusage-2.0.2.tgz#3f8c4b19ba7ea438a733d093661e92b60e5f88ee"
@@ -9378,7 +9381,7 @@ picocolors@^1.0.0:
   resolved "https://registry.yarnpkg.com/picocolors/-/picocolors-1.0.0.tgz#cb5bdc74ff3f51892236eaf79d68bc44564ab81c"
   integrity sha512-1fygroTLlHu66zi26VoTDv8yRgm0Fccecssto+MhsZ0D/DGW2sm8E8AjW7NU5VVTRt5GxbeZ5qBuJr+HyLYkjQ==
 
-picomatch@^2.0.4, picomatch@^2.2.1, picomatch@^2.3.1:
+picomatch@2.3.1, picomatch@^2.0.4, picomatch@^2.2.1, picomatch@^2.3.1:
   version "2.3.1"
   resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.3.1.tgz#3ba3833733646d9d3e4995946c1365a67fb07a42"
   integrity sha512-JU3teHTNjmE2VCGFzuY8EXzCDVwEqB2a8fsIvwaStHhAWJEeVd1o1QD80CU6+ZdEXXSLbSsuLwJjkCBWqRQUVA==
@@ -10308,7 +10311,6 @@ sass@^1.55.0:
 
 "sauce-connect-proxy@https://saucelabs.com/downloads/sc-4.8.1-linux.tar.gz":
   version "0.0.0"
-  uid "9c16682e4c9716734432789884f868212f95f563"
   resolved "https://saucelabs.com/downloads/sc-4.8.1-linux.tar.gz#9c16682e4c9716734432789884f868212f95f563"
 
 saucelabs@^1.5.0: