refactor(@schematics/update): add automated JSON schema generation

Author: hansl

packages/schematics/update/BUILD

@@ -7,6 +7,7 @@ licenses(["notice"])  # MIT
 
 load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
+load("//tools:ts_json_schema.bzl", "ts_json_schema")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -20,12 +21,9 @@ ts_library(
             "**/*_benchmark.ts",
         ],
     ),
-    data = [
-        "collection.json",
-        "migrate/schema.json",
-        "update/schema.json",
-    ],
     deps = [
+        ":migrate_schema",
+        ":update_schema",
         "//packages/angular_devkit/core",
         "//packages/angular_devkit/schematics",
         "//packages/angular_devkit/schematics:tasks",
@@ -35,6 +33,16 @@ ts_library(
     ],
 )
 
+ts_json_schema(
+    name = "update_schema",
+    src = "update/schema.json",
+)
+
+ts_json_schema(
+    name = "migrate_schema",
+    src = "migrate/schema.json",
+)
+
 ts_library(
     name = "update_test_lib",
     srcs = glob(

packages/schematics/update/migrate/index.ts

@@ -15,7 +15,7 @@ import {
   externalSchematic,
 } from '@angular-devkit/schematics';
 import * as semver from 'semver';
-import { PostUpdateSchema } from './schema';
+import { Schema as PostUpdateSchema } from './schema';
 
 
 /**

packages/schematics/update/migrate/schema.ts

@@ -20,7 +20,7 @@ import * as semver from 'semver';
 import { getNpmPackageJson } from './npm';
 import { NpmRepositoryPackageJson } from './npm-package-json';
 import { Dependency, JsonSchemaForNpmPackageJsonFiles } from './package-json';
-import { UpdateSchema } from './schema';
+import { Schema as UpdateSchema } from './schema';
 
 type VersionRange = string & { __VERSION_RANGE: void; };
 type PeerVersionTransform = string | ((range: string) => string);
@@ -758,9 +758,11 @@ export default function(options: UpdateSchema): Rule {
     // We cannot just return this because we need to fetch the packages from NPM still for the
     // help/guide to show.
     options.packages = [];
-  } else if (typeof options.packages == 'string') {
-    // If a string, then we should split it and make it an array.
-    options.packages = options.packages.split(/,/g);
+  } else {
+    // We split every packages by commas to allow people to pass in multiple and make it an array.
+    options.packages = options.packages.reduce((acc, curr) => {
+      return acc.concat(curr.split(','));
+    }, [] as string[]);
   }
 
   if (options.migrateOnly && options.from) {
@@ -852,9 +854,9 @@ export default function(options: UpdateSchema): Rule {
             logger.createChild(''),
             'warn',
           );
-          _validateUpdatePackages(infoMap, options.force, sublog);
+          _validateUpdatePackages(infoMap, !!options.force, sublog);
 
-          return _performUpdate(tree, context, infoMap, logger, options.migrateOnly);
+          return _performUpdate(tree, context, infoMap, logger, !!options.migrateOnly);
         } else {
           return _usageMessage(options, infoMap, logger);
         }

packages/schematics/update/update/index.ts

@@ -54,5 +54,7 @@
         }
       ]
     }
-  }
+  },
+  "required": [
+  ]
 }