test(@angular-devkit/build-angular): remove unneeded custom Jasmine test timeouts

The default Jasmine test timeout is set to 2.5 minutes for all builder tests. The smaller timeouts (that are now removed from individual tests) can lead to test flakes especially on CI which can have large performance variability.

Author: clydin

packages/angular_devkit/build_angular/src/browser/specs/styles_spec.ts

@@ -266,7 +266,7 @@ describe('Browser Builder styles', () => {
 
     const overrides = { extractCss: true, styles: [`src/styles.scss`] };
     await browserBuild(architect, host, target, overrides);
-  }, 30000);
+  });
 
   it(`supports font-awesome imports (tilde)`, async () => {
     host.writeMultipleFiles({
@@ -278,7 +278,7 @@ describe('Browser Builder styles', () => {
 
     const overrides = { extractCss: true, styles: [`src/styles.scss`] };
     await browserBuild(architect, host, target, overrides);
-  }, 30000);
+  });
 
   it(`supports font-awesome imports without extractCss`, async () => {
     host.writeMultipleFiles({
@@ -289,7 +289,7 @@ describe('Browser Builder styles', () => {
 
     const overrides = { extractCss: false, styles: [`src/styles.scss`] };
     await browserBuild(architect, host, target, overrides);
-  }, 30000);
+  });
 
   it(`uses autoprefixer`, async () => {
     host.writeMultipleFiles({
@@ -456,7 +456,7 @@ describe('Browser Builder styles', () => {
     main = await files['main.js'];
     expect(styles).toContain(`url('/assets/global-img-absolute.svg')`);
     expect(main).toContain(`url('/assets/component-img-absolute.svg')`);
-  }, 90000);
+  });
 
   it(`supports bootstrap@4 with full path`, async () => {
     const bootstrapPath = dirname(require.resolve('bootstrap/package.json'));

packages/angular_devkit/build_angular/src/dev-server/hmr_spec.ts

@@ -112,7 +112,7 @@ describe('Dev Server Builder HMR', () => {
         take(2),
       )
       .toPromise();
-  }, 30000);
+  });
 
   it('works for TS changes', async () => {
     const run = await architect.scheduleTarget(target, overrides);
@@ -147,7 +147,7 @@ describe('Dev Server Builder HMR', () => {
         take(2),
       )
       .toPromise();
-  }, 30000);
+  });
 
   it('restores input and select values', async () => {
     const run = await architect.scheduleTarget(target, overrides);
@@ -191,5 +191,5 @@ describe('Dev Server Builder HMR', () => {
         take(2),
       )
       .toPromise();
-  }, 30000);
+  });
 });

packages/angular_devkit/build_angular/src/dev-server/live-reload_spec.ts

@@ -184,7 +184,7 @@ describe('Dev Server Builder live-reload', () => {
         take(2),
       )
       .toPromise();
-  }, 30000);
+  });
 
   it('works without http -> http proxy', async () => {
     const run = await architect.scheduleTarget(target, overrides);
@@ -215,7 +215,7 @@ describe('Dev Server Builder live-reload', () => {
         take(2),
       )
       .toPromise();
-  }, 30000);
+  });
 
   it('works without https -> http proxy', async () => {
     const run = await architect.scheduleTarget(target, overrides);
@@ -246,7 +246,7 @@ describe('Dev Server Builder live-reload', () => {
         take(2),
       )
       .toPromise();
-  }, 30000);
+  });
 
   it('works without https -> http proxy without websockets (dotnet emulation)', async () => {
     const run = await architect.scheduleTarget(target, overrides);
@@ -279,5 +279,5 @@ describe('Dev Server Builder live-reload', () => {
         take(2),
       )
       .toPromise();
-  }, 30000);
+  });
 });

packages/angular_devkit/build_angular/src/dev-server/ssl_spec.ts

@@ -40,7 +40,7 @@ describe('Dev Server Builder ssl', () => {
       agent: new https.Agent({ rejectUnauthorized: false }),
     });
     expect(await response.text()).toContain('<title>HelloWorldApp</title>');
-  }, 30000);
+  });
 
   it('supports key and cert', async () => {
     host.writeMultipleFiles({
@@ -116,5 +116,5 @@ describe('Dev Server Builder ssl', () => {
       agent: new https.Agent({ rejectUnauthorized: false }),
     });
     expect(await response.text()).toContain('<title>HelloWorldApp</title>');
-  }, 30000);
+  });
 });

packages/angular_devkit/build_angular/src/dev-server/works_spec.ts

@@ -36,7 +36,7 @@ describe('Dev Server Builder', () => {
 
     const response = await fetch('http://localhost:4200/index.html');
     expect(await response.text()).toContain('<title>HelloWorldApp</title>');
-  }, 30000);
+  });
 
   it(`doesn't serve files on the cwd directly`, async () => {
     const run = await architect.scheduleTarget(target);
@@ -98,7 +98,7 @@ describe('Dev Server Builder', () => {
     expect(output.success).toBe(true);
     const response = await fetch('http://localhost:4200/index.html');
     expect(response.headers.get('X-Header')).toBe('Hello World');
-  }, 30000);
+  });
 
   it('uses source locale when not localizing', async () => {
     const config = host.scopedSync().read(normalize('angular.json'));

packages/angular_devkit/build_angular/src/extract-i18n/works_spec.ts

@@ -36,7 +36,7 @@ describe('Extract i18n Target', () => {
       const content = virtualFs.fileBufferToString(host.scopedSync().read(extractionFile));
       expect(content).toContain('i18n test');
     }
-  }, 30000);
+  });
 
   it('does not emit the application files', async () => {
     host.appendToFile('src/app/app.component.html', '<p i18n>i18n test</p>');
@@ -48,7 +48,7 @@ describe('Extract i18n Target', () => {
     await run.stop();
 
     expect(host.scopedSync().exists(normalize('dist/app/main.js'))).toBeFalse();
-  }, 30000);
+  });
 
   it('shows errors', async () => {
     const logger = new logging.Logger('');
@@ -65,7 +65,7 @@ describe('Extract i18n Target', () => {
     await run.stop();
 
     expect(logs.join()).toMatch('Cannot mark an element as translatable inside of a translatable section');
-  }, 30000);
+  });
 
   it('supports out file', async () => {
     host.appendToFile('src/app/app.component.html', '<p i18n>i18n test</p>');
@@ -82,7 +82,7 @@ describe('Extract i18n Target', () => {
     expect(host.scopedSync().exists(extractionFile)).toBe(true);
     expect(virtualFs.fileBufferToString(host.scopedSync().read(extractionFile)))
       .toMatch(/i18n test/);
-  }, 30000);
+  });
 
   it('supports output path', async () => {
     host.appendToFile('src/app/app.component.html', '<p i18n>i18n test</p>');
@@ -100,7 +100,7 @@ describe('Extract i18n Target', () => {
     expect(host.scopedSync().exists(extractionFile)).toBe(true);
     expect(virtualFs.fileBufferToString(host.scopedSync().read(extractionFile)))
       .toMatch(/i18n test/);
-  }, 30000);
+  });
 
   it('supports i18n format', async () => {
     host.appendToFile('src/app/app.component.html', '<p i18n>i18n test</p>');
@@ -116,7 +116,7 @@ describe('Extract i18n Target', () => {
     expect(host.scopedSync().exists(extractionFile)).toBe(true);
     expect(virtualFs.fileBufferToString(host.scopedSync().read(extractionFile)))
       .toMatch(/i18n test/);
-  }, 30000);
+  });
 
   it('issues warnings for duplicate message identifiers', async () => {
     host.appendToFile(
@@ -140,5 +140,5 @@ describe('Extract i18n Target', () => {
       'Duplicate messages with id',
     );
 
-  }, 30000);
+  });
 });

packages/angular_devkit/build_angular/src/karma/code-coverage_spec.ts

@@ -52,7 +52,7 @@ describe('Karma Builder code coverage', () => {
       expect(content).toContain('app.component.ts');
       expect(content).toContain('test.ts');
     }
-  }, 120000);
+  });
 
   it('supports code coverage exclude option', async () => {
     const overrides = {
@@ -78,7 +78,7 @@ describe('Karma Builder code coverage', () => {
       const content = virtualFs.fileBufferToString(host.scopedSync().read(coverageFilePath));
       expect(content).not.toContain('test.ts');
     }
-  }, 120000);
+  });
 
   it(`should collect coverage from paths in 'sourceRoot'`, async () => {
     const files: { [path: string]: string } = {
@@ -130,7 +130,7 @@ describe('Karma Builder code coverage', () => {
       const content = virtualFs.fileBufferToString(host.scopedSync().read(coverageFilePath));
       expect(content).not.toContain('my-lib');
     }
-  }, 120000);
+  });
 
   it('should exit with non-zero code when coverage is below threshold', async () => {
     host.replaceInFile('karma.conf.js', 'coverageReporter: {', `
@@ -168,7 +168,7 @@ describe('Karma Builder code coverage', () => {
 
     await run.stop();
 
-  }, 120000);
+  });
 
   it('is able to process coverage plugin provided as string', async () => {
     host.replaceInFile('karma.conf.js', /plugins: \[.+?\]/s, `plugins: [
@@ -183,7 +183,7 @@ describe('Karma Builder code coverage', () => {
     const {success} = await run.result;
     expect(success).toBe(true);
     await run.stop();
-  }, 120000);
+  });
 
   it('is able to process coverage plugins provided as string karma-*', async () => {
     host.replaceInFile('karma.conf.js', /plugins: \[.+?\]/s, `plugins: [
@@ -195,5 +195,5 @@ describe('Karma Builder code coverage', () => {
     const {success} = await run.result;
     expect(success).toBe(true);
     await run.stop();
-  }, 120000);
+  });
 });

packages/angular_devkit/build_angular/src/protractor/works_spec.ts

@@ -25,7 +25,7 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
 
     await run.stop();
-  }, 30000);
+  });
 
   it('fails with no devServerTarget and no standalone server', async () => {
     const overrides = { devServerTarget: undefined } as unknown as JsonObject;
@@ -34,7 +34,7 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: false }));
 
     await run.stop();
-  }, 30000);
+  });
 
   it('overrides protractor specs', async () => {
     host.scopedSync().rename(
@@ -48,7 +48,7 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
 
     await run.stop();
-  }, 60000);
+  });
 
   it('overrides protractor suites', async () => {
     host.scopedSync().rename(
@@ -70,7 +70,7 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
 
     await run.stop();
-  }, 60000);
+  });
 
   it('supports automatic port assignment (port = 0)', async () => {
     const overrides = { port: 0 };
@@ -79,7 +79,7 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
 
     await run.stop();
-  }, 30000);
+  });
 
   it('supports dev server builder with browser builder base HREF option', async () => {
     host.replaceInFile(
@@ -95,7 +95,7 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
 
     await run.stop();
-  }, 30000);
+  });
 
   it('supports running tests by pattern', async () => {
     host.writeMultipleFiles({
@@ -112,7 +112,7 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
 
     await run.stop();
-  }, 30000);
+  });
 
   it('supports running tests excluding a pattern', async () => {
     host.writeMultipleFiles({
@@ -129,5 +129,5 @@ describe('Protractor Builder', () => {
     await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
 
     await run.stop();
-  }, 30000);
+  });
 });

packages/angular_devkit/build_angular/src/tslint/works_spec.ts

@@ -48,7 +48,7 @@ describe('Tslint Target', () => {
     const output = await run.result;
     expect(output.success).toBe(true);
     await run.stop();
-  }, 30000);
+  });
 
   it(`should show project name as status and in the logs`, async () => {
     // Check logs.
@@ -99,7 +99,7 @@ describe('Tslint Target', () => {
     expect(allStatus).toContain(jasmine.stringMatching(/linting.*"app".*/i));
     expect(allLogs).not.toContain(jasmine.stringMatching(/linting.*"app".*/i));
     await run.stop();
-  }, 30000);
+  });
 
   // it('should report lint error once', (done) => {
   //   host.writeMultipleFiles({'src/app/app.component.ts': 'const foo = "";\n' });