build: disconnect @npm workspace from main project

This will speed up significantly as we don't need to fetch all
dependencies again just for the `@npm` repository that is at this point
only leveraged by the `ng_package` rule for some of its dependencies.

This commit allows us to drop the `yarn.lock` and Aspect lock files, and
allows us to independently migrate `ng_package` to `rules_js`.

It also allows us to drop the `_rjs` TS interop layer in follow-up commits.

Author: devversion

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -3,7 +3,7 @@
 # This file should be checked into version control along with the pnpm-lock.yaml file.
 .npmrc=-1406867100
 modules/testing/builder/package.json=973445093
-package.json=1084945472
+package.json=577630563
 packages/angular/build/package.json=1235849957
 packages/angular/cli/package.json=-1917515334
 packages/angular/pwa/package.json=1108903917
@@ -17,7 +17,7 @@ packages/angular_devkit/schematics/package.json=-1133510866
 packages/angular_devkit/schematics_cli/package.json=-2026655035
 packages/ngtools/webpack/package.json=71458652
 packages/schematics/angular/package.json=251715148
-pnpm-lock.yaml=-699735310
+pnpm-lock.yaml=1658089886
 pnpm-workspace.yaml=-1264044456
 tests/package.json=700948366
 yarn.lock=958506060

WORKSPACE

@@ -110,20 +110,18 @@ rules_js_register_toolchains(
 
 load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
 
+# TODO(devversion): Remove this once `ng_package` is ported over to `rules_js`.
 yarn_install(
     name = "npm",
     data = [
         "//:.yarn/releases/yarn-4.5.0.cjs",
         "//:.yarnrc.yml",
-        "//:patches/@angular+bazel+20.0.0-next.1.patch",
+        "//tools/legacy-rnjs:.yarn/patches/@angular-bazel-https-24aa003e56.patch",
     ],
-    # Currently disabled due to:
-    #  1. Missing Windows support currently.
-    #  2. Incompatibilites with the `ts_library` rule.
     exports_directories_only = False,
-    package_json = "//:package.json",
+    package_json = "//tools/legacy-rnjs:package.json",
     yarn = "//:.yarn/releases/yarn-4.5.0.cjs",
-    yarn_lock = "//:yarn.lock",
+    yarn_lock = "//tools/legacy-rnjs:yarn.lock",
 )
 
 http_archive(

package.json

@@ -44,7 +44,6 @@
   "devDependencies": {
     "@ampproject/remapping": "2.3.0",
     "@angular/animations": "20.0.0-next.1",
-    "@angular/bazel": "https://github.com/angular/bazel-builds.git#3422dcb650e407d2c00ac724acf560ab1506d68c",
     "@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#d4727212a9d0f7eb63ae3116d73c769d9bd0bdc1",
     "@angular/cdk": "20.0.0-next.0",
     "@angular/common": "20.0.0-next.1",

packages/angular/ssr/node/test/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm//@angular/build-tooling/bazel/spec-bundling:index.bzl", "spec_bundle")
+load("@devinfra//bazel/spec-bundling:index_rjs.bzl", "spec_bundle")
 load("//tools:defaults2.bzl", "jasmine_test", "ts_project")
 
 ts_project(
@@ -14,9 +14,6 @@ ts_project(
 # TODO: Clean this up when this repo runs ESM consistently.
 spec_bundle(
     name = "esm_tests_bundled",
-    downlevel_async_await = False,
-    platform = "node",
-    run_angular_linker = False,
     deps = [
         ":unit_test_lib",
     ],

packages/angular/ssr/test/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@npm//@angular/build-tooling/bazel/spec-bundling:index.bzl", "spec_bundle")
+load("@devinfra//bazel/spec-bundling:index_rjs.bzl", "spec_bundle")
 load("//tools:defaults2.bzl", "jasmine_test", "ts_project")
 
 ts_project(
@@ -20,13 +20,8 @@ ts_project(
     ],
 )
 
-# TODO: Replace this with a `rules_js` variant, or make the SSR package
-# native ESM compatible! (import extensions etc.)
 spec_bundle(
     name = "esm_tests_bundled",
-    downlevel_async_await = False,
-    platform = "node",
-    run_angular_linker = False,
     deps = [
         ":unit_test_lib",
     ],

patches/@angular+bazel+20.0.0-next.1.patch

@@ -9,8 +9,6 @@ ts_project(
     data = [
         "//tests/legacy-cli/e2e/ng-snapshot",
     ],
-    # TODO(devversion): Remove
-    enable_runtime_rnjs_interop = False,
     deps = [
         "//:node_modules/@types/jasmine",
         "//:node_modules/@types/node",

pnpm-lock.yaml

@@ -107,33 +107,10 @@ def ts_project(
         testonly = False,
         visibility = None,
         ignore_strict_deps = False,
-        enable_runtime_rnjs_interop = True,
         **kwargs):
-    interop_deps = []
-
-    # Pull in the `rules_nodejs` variants of dependencies we know are "hybrid". This
-    # is necessary as we can't mix `npm/node_modules` from RNJS with the pnpm-style
-    # symlink-dependent node modules. In addition, we need to extract `_rjs` interop
-    # dependencies so that we can forward and capture the module mappings for runtime
-    # execution, with regards to first-party dependency linking.
-    rjs_modules_to_rnjs = []
-    if enable_runtime_rnjs_interop:
-        for d in deps:
-            if d.startswith("//:node_modules/"):
-                rjs_modules_to_rnjs.append(d.replace("//:node_modules/", "@npm//"))
-            if d.endswith("_rjs"):
-                rjs_modules_to_rnjs.append(d.replace("_rjs", ""))
-
     if tsconfig == None:
         tsconfig = "//:test-tsconfig" if testonly else "//:build-tsconfig"
 
-    ts_deps_interop(
-        name = "%s_interop_deps" % name,
-        deps = [] + interop_deps + rjs_modules_to_rnjs,
-        visibility = visibility,
-        testonly = testonly,
-    )
-
     _ts_project(
         name = "%s_rjs" % name,
         testonly = testonly,
@@ -145,7 +122,7 @@ def ts_project(
         # worker for efficient, fast DX and avoiding Windows no-sandbox issues.
         supports_workers = 1,
         tsc_worker = "//tools:vanilla_ts_worker",
-        deps = [":%s_interop_deps" % name] + deps,
+        deps = deps,
         **kwargs
     )
 
@@ -161,9 +138,7 @@ def ts_project(
         testonly = testonly,
         visibility = visibility,
         dep = "%s_rjs" % name,
-        # Forwarded dependencies for linker module mapping aspect.
-        # RJS deps can also transitively pull in module mappings from their `interop_deps`.
-        deps = [] + ["%s_interop_deps" % name] + deps,
+        deps = deps,
         module_name = module_name,
     )
 

tests/legacy-cli/e2e/utils/BUILD.bazel

@@ -0,0 +1,9 @@
+node_modules/
+
+# Yarn
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions