Revert "test: Introduce delay for file write to minimize flakiness"

This reverts commit 533fd21.

Author: alan-agius4

tests/legacy-cli/e2e/tests/vite/reuse-dep-optimization-cache.ts

@@ -39,6 +39,6 @@ export default async function () {
     ['serve', '--port=0'],
     /Hash is consistent\. Skipping/,
     // Use CI:0 to force caching
-    { DEBUG: 'vite:deps', CI: '0', NO_COLOR: 'true' },
+    { DEBUG: 'vite:deps', CI: '0' },
   );
 }

tests/legacy-cli/e2e/tests/vite/ssr-new-dep-optimization.ts

@@ -1,15 +1,9 @@
 import assert from 'node:assert';
-import { setTimeout } from 'node:timers/promises';
-import {
-  execAndWaitForOutputToMatch,
-  ng,
-  waitForAnyProcessOutputToMatch,
-} from '../../utils/process';
+import { ng, waitForAnyProcessOutputToMatch } from '../../utils/process';
 import { installWorkspacePackages, uninstallPackage } from '../../utils/packages';
-import { useSha } from '../../utils/project';
+import { ngServe, useSha } from '../../utils/project';
 import { getGlobalVariable } from '../../utils/env';
 import { readFile, writeFile } from '../../utils/fs';
-import { findFreePort } from '../../utils/network';
 
 export default async function () {
   assert(
@@ -27,27 +21,21 @@ export default async function () {
   await useSha();
   await installWorkspacePackages();
 
-  // The Node.js specific module should not be found
-  const port = await findFreePort();
-  await execAndWaitForOutputToMatch(
-    'ng',
-    ['serve', '--port', port.toString()],
-    /Application bundle generation complete/,
-    { CI: '0', NO_COLOR: 'true' },
-  );
+  const port = await ngServe();
   await validateResponse('/', /Hello,/);
 
-  const appConfigContentsUpdated = `
-    import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
-    ${(await readFile('src/app/app.config.ts')).replace('provideRouter(routes),', 'provideAnimationsAsync(), provideRouter(routes),')}
-  `;
-
   await Promise.all([
     waitForAnyProcessOutputToMatch(
       /new dependencies optimized: @angular\/platform-browser\/animations\/async/,
       6000,
     ),
-    setTimeout(200).then(() => writeFile('src/app/app.config.ts', appConfigContentsUpdated)),
+    writeFile(
+      'src/app/app.config.ts',
+      `
+      import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
+      ${(await readFile('src/app/app.config.ts')).replace('provideRouter(routes),', 'provideAnimationsAsync(), provideRouter(routes),')}
+    `,
+    ),
   ]);
 
   // Verify the app still works.