refactor: strip leading slash to prevent confusion

Author: alan-agius4

packages/angular/cli/commands/update-impl.ts

@@ -97,7 +97,8 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
           files.add(eventPath);
           break;
         case 'rename':
-          logs.push(`${colors.blue('RENAME')} ${eventPath} => ${event.to}`);
+          const eventToPath = event.to.startsWith('/') ? event.to.substr(1) : event.to;
+          logs.push(`${colors.blue('RENAME')} ${eventPath} => ${eventToPath}`);
           files.add(eventPath);
           break;
       }

packages/angular/cli/models/schematic-command.ts

@@ -513,7 +513,8 @@ export abstract class SchematicCommand<
           loggingQueue.push(`${colors.yellow('DELETE')} ${eventPath}`);
           break;
         case 'rename':
-          loggingQueue.push(`${colors.blue('RENAME')} ${eventPath} => ${event.to}`);
+          const eventToPath = event.to.startsWith('/') ? event.to.substr(1) : event.to;
+          loggingQueue.push(`${colors.blue('RENAME')} ${eventPath} => ${eventToPath}`);
           break;
       }
     });

packages/angular_devkit/schematics_cli/bin/schematics.ts

@@ -189,29 +189,32 @@ export async function main({
    */
   workflow.reporter.subscribe((event: DryRunEvent) => {
     nothingDone = false;
+    // Strip leading slash to prevent confusion.
+    const eventPath = event.path.startsWith('/') ? event.path.substr(1) : event.path;
 
     switch (event.kind) {
       case 'error':
         error = true;
 
         const desc = event.description == 'alreadyExist' ? 'already exists' : 'does not exist';
-        logger.error(`ERROR! ${event.path} ${desc}.`);
+        logger.error(`ERROR! ${eventPath} ${desc}.`);
         break;
       case 'update':
         loggingQueue.push(tags.oneLine`
-        ${terminal.white('UPDATE')} ${event.path} (${event.content.length} bytes)
+        ${terminal.white('UPDATE')} ${eventPath} (${event.content.length} bytes)
       `);
         break;
       case 'create':
         loggingQueue.push(tags.oneLine`
-        ${terminal.green('CREATE')} ${event.path} (${event.content.length} bytes)
+        ${terminal.green('CREATE')} ${eventPath} (${event.content.length} bytes)
       `);
         break;
       case 'delete':
-        loggingQueue.push(`${terminal.yellow('DELETE')} ${event.path}`);
+        loggingQueue.push(`${terminal.yellow('DELETE')} ${eventPath}`);
         break;
       case 'rename':
-        loggingQueue.push(`${terminal.blue('RENAME')} ${event.path} => ${event.to}`);
+        const eventToPath = event.to.startsWith('/') ? event.to.substr(1) : event.to;
+        loggingQueue.push(`${terminal.blue('RENAME')} ${eventPath} => ${eventToPath}`);
         break;
     }
   });

packages/angular_devkit/schematics_cli/bin/schematics_spec.ts

@@ -46,20 +46,20 @@ describe('schematics-cli binary', () => {
   it('dry-run works', async () => {
     const args = ['blank', 'foo', '--dry-run'];
     const res = await main({ args, stdout, stderr });
-    expect(stdout.lines).toMatch(/CREATE \/foo\/README.md/);
-    expect(stdout.lines).toMatch(/CREATE \/foo\/.gitignore/);
-    expect(stdout.lines).toMatch(/CREATE \/foo\/src\/foo\/index.ts/);
-    expect(stdout.lines).toMatch(/CREATE \/foo\/src\/foo\/index_spec.ts/);
+    expect(stdout.lines).toMatch(/CREATE foo\/README.md/);
+    expect(stdout.lines).toMatch(/CREATE foo\/.gitignore/);
+    expect(stdout.lines).toMatch(/CREATE foo\/src\/foo\/index.ts/);
+    expect(stdout.lines).toMatch(/CREATE foo\/src\/foo\/index_spec.ts/);
     expect(res).toEqual(0);
   });
 
   it('dry-run is default when debug mode', async () => {
     const args = ['blank', 'foo', '--debug'];
     const res = await main({ args, stdout, stderr });
-    expect(stdout.lines).toMatch(/CREATE \/foo\/README.md/);
-    expect(stdout.lines).toMatch(/CREATE \/foo\/.gitignore/);
-    expect(stdout.lines).toMatch(/CREATE \/foo\/src\/foo\/index.ts/);
-    expect(stdout.lines).toMatch(/CREATE \/foo\/src\/foo\/index_spec.ts/);
+    expect(stdout.lines).toMatch(/CREATE foo\/README.md/);
+    expect(stdout.lines).toMatch(/CREATE foo\/.gitignore/);
+    expect(stdout.lines).toMatch(/CREATE foo\/src\/foo\/index.ts/);
+    expect(stdout.lines).toMatch(/CREATE foo\/src\/foo\/index_spec.ts/);
     expect(res).toEqual(0);
   });