Skip to content

Commit a4d091c

Browse files
alan-agius4clydin
authored andcommitted
ci: remove validate-do-not-submit check
This uses `git merge-base --fork-point master` which currently is not yielding a SHA on the patch branch. In some cases merge-base will not working as expected when base is ahead. See https://public-inbox.org/git/[email protected]/T/#r3830f032d76f39b82d0ffe7f8bd77351cf634d29 This validation checks if `DO_NOT_SUBMIT` string literal has been added using `git diff`, when present validation will fail. This check is unneeded as we do not use the `DO_NOT_SUBMIT` pattern, as we typically use `wip!` commit message types. (cherry picked from commit ab84fc5)
1 parent 76d813f commit a4d091c

File tree

2 files changed

+0
-81
lines changed

2 files changed

+0
-81
lines changed

scripts/validate-do-not-submit.ts

Lines changed: 0 additions & 75 deletions
This file was deleted.

scripts/validate.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { execSync } from 'child_process';
1111
import templates from './templates';
1212
import validateBuildFiles from './validate-build-files';
1313
import validateCommits from './validate-commits';
14-
import validateDoNotSubmit from './validate-do-not-submit';
1514
import validateLicenses from './validate-licenses';
1615
import validateUserAnalytics from './validate-user-analytics';
1716

@@ -48,11 +47,6 @@ export default async function (options: { verbose: boolean }, logger: logging.Lo
4847
|| error;
4948
}
5049

51-
logger.info('');
52-
logger.info(`Running DO_NOT${''}_SUBMIT validation...`);
53-
error = await validateDoNotSubmit({}, logger.createChild('validate-do-not-submit')) != 0
54-
|| error;
55-
5650
logger.info('');
5751
logger.info('Running license validation...');
5852
error = await validateLicenses({}, logger.createChild('validate-commits')) != 0

0 commit comments

Comments
 (0)