Skip to content

Commit a7de97e

Browse files
clydinalan-agius4
authored andcommitted
build: add Bazel ts_library rule package_name properties to all packages
rules_nodejs 4 requires that a package_name property be specified within a ts_library rule for the output to be linked into the package repository. Failing to add the property can cause test failures due to unresolved packages.
1 parent b3d5fa4 commit a7de97e

File tree

13 files changed

+13
-0
lines changed

13 files changed

+13
-0
lines changed

packages/angular/cli/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package(default_visibility = ["//visibility:public"])
1919

2020
ts_library(
2121
name = "angular-cli",
22+
package_name = "@angular/cli",
2223
srcs = glob(
2324
include = ["**/*.ts"],
2425
exclude = [

packages/angular/pwa/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:public"])
1313

1414
ts_library(
1515
name = "pwa",
16+
package_name = "@angular/pwa",
1617
srcs = glob(
1718
["**/*.ts"],
1819
# Currently, this library is used only with the rollup plugin.

packages/angular_devkit/architect/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ ts_json_schema(
3939

4040
ts_library(
4141
name = "architect",
42+
package_name = "@angular-devkit/architect",
4243
srcs = glob(
4344
include = ["src/**/*.ts"],
4445
exclude = ["**/*_spec.ts"],

packages/angular_devkit/architect_cli/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ package(default_visibility = ["//visibility:public"])
1010

1111
ts_library(
1212
name = "architect_cli",
13+
package_name = "@angular-devkit/architect-cli",
1314
srcs = [
1415
"bin/architect.ts",
1516
] + glob(["src/**/*.ts"]),

packages/angular_devkit/benchmark/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package(default_visibility = ["//visibility:public"])
1717

1818
ts_library(
1919
name = "benchmark",
20+
package_name = "@angular-devkit/benchmark",
2021
srcs = glob(
2122
include = ["src/**/*.ts"],
2223
exclude = [

packages/angular_devkit/build_angular/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ ts_json_schema(
5959

6060
ts_library(
6161
name = "build_angular",
62+
package_name = "@angular-devkit/build-angular",
6263
srcs = glob(
6364
include = [
6465
"src/**/*.ts",

packages/angular_devkit/build_optimizer/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package(default_visibility = ["//visibility:public"])
1818

1919
ts_library(
2020
name = "build_optimizer",
21+
package_name = "@angular-devkit/build-optimizer",
2122
srcs = glob(
2223
include = ["src/**/*.ts"],
2324
exclude = [

packages/angular_devkit/build_webpack/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ ts_json_schema(
2929

3030
ts_library(
3131
name = "build_webpack",
32+
package_name = "@angular-devkit/build-webpack",
3233
srcs = glob(
3334
include = ["src/**/*.ts"],
3435
exclude = [

packages/angular_devkit/core/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ licenses(["notice"]) # MIT License
1919

2020
ts_library(
2121
name = "core",
22+
package_name = "@angular-devkit/core",
2223
srcs = glob(
2324
include = ["src/**/*.ts"],
2425
exclude = [

packages/angular_devkit/schematics/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ licenses(["notice"])
1919

2020
ts_library(
2121
name = "schematics",
22+
package_name = "@angular-devkit/schematics",
2223
srcs = glob(
2324
include = ["src/**/*.ts"],
2425
exclude = [

0 commit comments

Comments
 (0)