refactor: clean up copying of assets

This code can now be cleaned up by using Node.js APIs

Author: alan-agius4

tests/legacy-cli/e2e/utils/assets.ts

@@ -1,45 +1,33 @@
-import { join } from 'node:path';
-import { chmod } from 'node:fs/promises';
-import glob from 'fast-glob';
+import { join, resolve } from 'node:path';
+import { cp } from 'node:fs/promises';
 import { getGlobalVariable } from './env';
-import { resolve } from 'node:path';
 import { copyFile } from './fs';
 import { installWorkspacePackages, setRegistry } from './packages';
 import { useBuiltPackagesVersions } from './project';
 
-export function assetDir(assetName: string) {
+export function assetDir(assetName: string): string {
   return join(__dirname, '../e2e/assets', assetName);
 }
 
-export function copyProjectAsset(assetName: string, to?: string) {
+export function copyProjectAsset(assetName: string, to?: string): Promise<void> {
   const tempRoot = join(getGlobalVariable('projects-root'), 'test-project');
   const sourcePath = assetDir(assetName);
   const targetPath = join(tempRoot, to || assetName);
 
   return copyFile(sourcePath, targetPath);
 }
 
-export function copyAssets(assetName: string, to?: string) {
+export async function copyAssets(assetName: string, to?: string): Promise<string> {
   const seed = +Date.now();
-  const tempRoot = join(getGlobalVariable('projects-root'), 'assets', assetName + '-' + seed);
+  const tempRoot = join(getGlobalVariable('projects-root'), 'assets', `${assetName}-${seed}`);
   const root = assetDir(assetName);
 
-  return Promise.resolve()
-    .then(() => {
-      const allFiles = glob.sync('**/*', { dot: true, cwd: root });
+  const destinationPath =
+    to !== undefined ? resolve(getGlobalVariable('projects-root'), 'test-project', to) : tempRoot;
 
-      return allFiles.reduce((promise, filePath) => {
-        const toPath =
-          to !== undefined
-            ? resolve(getGlobalVariable('projects-root'), 'test-project', to, filePath)
-            : join(tempRoot, filePath);
+  await cp(root, destinationPath, { recursive: true, mode: 0o777 });
 
-        return promise
-          .then(() => copyFile(join(root, filePath), toPath))
-          .then(() => chmod(toPath, 0o777));
-      }, Promise.resolve());
-    })
-    .then(() => tempRoot);
+  return destinationPath;
 }
 
 /**
@@ -59,6 +47,7 @@ export async function createProjectFromAsset(
   if (!useNpmPackages) {
     await useBuiltPackagesVersions();
   }
+
   if (!skipInstall) {
     await installWorkspacePackages();
   }