Skip to content

Commit cfc58a0

Browse files
clydinhansl
authored andcommitted
refactor(@angular/cli): simplify module resolution options
1 parent 7bdfcbd commit cfc58a0

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

packages/@angular/cli/models/webpack-configs/common.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,17 +197,23 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
197197
alias = rxPaths(nodeModules);
198198
} catch (e) { }
199199

200+
// Allow loaders to be in a node_modules nested inside the CLI package
201+
const loaderNodeModules = ['node_modules'];
202+
const potentialNodeModules = path.join(__dirname, '..', '..', 'node_modules');
203+
if (isDirectory(potentialNodeModules)) {
204+
loaderNodeModules.push(potentialNodeModules);
205+
}
206+
200207
return {
201208
resolve: {
202209
extensions: ['.ts', '.js'],
203-
modules: ['node_modules', nodeModules],
204210
symlinks: !buildOptions.preserveSymlinks,
205211
alias
206212
},
207213
resolveLoader: {
208-
modules: [nodeModules, 'node_modules']
214+
modules: loaderNodeModules
209215
},
210-
context: __dirname,
216+
context: projectRoot,
211217
entry: entryPoints,
212218
output: {
213219
path: path.resolve(buildOptions.outputPath),

packages/@angular/cli/tasks/eject.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,6 @@ class JsonWebpackSerializer {
288288
private _resolveReplacer(value: any) {
289289
this.variableImports['rxjs/_esm5/path-mapping'] = 'rxPaths';
290290
return Object.assign({}, value, {
291-
modules: value.modules.map((x: string) => './' + path.relative(this._root, x)),
292291
alias: this._escape('rxPaths()')
293292
});
294293
}

0 commit comments

Comments
 (0)