Skip to content

Commit d3e1149

Browse files
Keen Yee Liauvikerman
authored andcommitted
build: add missing transitive deps for typescript (#12881)
add `strict_checks = False` for building inside Google.
1 parent 42f85be commit d3e1149

File tree

5 files changed

+17
-6
lines changed

5 files changed

+17
-6
lines changed

packages/angular/cli/BUILD

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@ ts_library(
1919
"**/*_spec_large.ts",
2020
],
2121
),
22-
data = glob(["**/*.json"]),
22+
data = glob(["**/*.json", "**/*.md"]),
2323
module_name = "@angular/cli",
24+
# strict_checks = False,
2425
deps = [
2526
":command_schemas",
2627
"//packages/angular_devkit/architect",

packages/angular_devkit/architect/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ ts_library(
2020
),
2121
module_name = "@angular-devkit/architect",
2222
module_root = "src/index.d.ts",
23+
# strict_checks = False,
2324
data = glob(["**/*.json"]),
2425
deps = [
2526
"//packages/angular_devkit/core",

packages/angular_devkit/core/BUILD

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ ts_library(
2424
data = glob(["**/*.json"]),
2525
module_name = "@angular-devkit/core",
2626
module_root = "src/index.d.ts",
27+
# strict_checks = False,
2728
deps = [
2829
"@rxjs",
2930
"@rxjs//operators",
@@ -44,6 +45,7 @@ ts_library(
4445
"src/**/*_spec_large.ts",
4546
],
4647
),
48+
# strict_checks = False,
4749
deps = [
4850
":core",
4951
":node",
@@ -145,6 +147,7 @@ ts_library(
145147
),
146148
module_name = "@angular-devkit/core/node/testing",
147149
module_root = "node/testing/index.d.ts",
150+
# strict_checks = False,
148151
deps = [
149152
":core",
150153
":node",

packages/angular_devkit/schematics/BUILD

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ ts_library(
2323
),
2424
module_name = "@angular-devkit/schematics",
2525
module_root = "src/index.d.ts",
26+
# strict_checks = False,
2627
deps = [
2728
"//packages/angular_devkit/core",
2829
"//packages/angular_devkit/core:node", # TODO: get rid of this for 6.0
@@ -60,9 +61,9 @@ jasmine_node_test(
6061
name = "schematics_test",
6162
srcs = [":schematics_test_lib"],
6263
deps = [
64+
"@npm//chokidar",
6365
"@npm//jasmine",
6466
"@npm//source-map",
65-
"@npm//chokidar",
6667
],
6768
)
6869

@@ -82,14 +83,16 @@ ts_library(
8283
),
8384
module_name = "@angular-devkit/schematics/tasks",
8485
module_root = "tasks/index.d.ts",
86+
# strict_checks = False,
8587
deps = [
8688
":schematics",
87-
"//packages/angular_devkit/core",
88-
"//packages/angular_devkit/core:node",
89-
"@rxjs",
90-
"@rxjs//operators",
9189
"@npm//@types/node",
9290
"@npm//tslint",
91+
"@npm//typescript",
92+
"@rxjs",
93+
"@rxjs//operators",
94+
"//packages/angular_devkit/core:node",
95+
"//packages/angular_devkit/core",
9396
],
9497
)
9598

@@ -106,6 +109,7 @@ ts_library(
106109
),
107110
module_name = "@angular-devkit/schematics/tasks/node",
108111
module_root = "tasks/node/index.d.ts",
112+
# strict_checks = False,
109113
deps = [
110114
":schematics",
111115
":tasks",
@@ -174,6 +178,7 @@ ts_library(
174178
),
175179
module_name = "@angular-devkit/schematics/tools",
176180
module_root = "tools/index.d.ts",
181+
# strict_checks = False,
177182
deps = [
178183
":schematics",
179184
":tasks",

packages/schematics/angular/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ ts_library(
4444
],
4545
),
4646
module_name = "@schematics/angular",
47+
# strict_checks = False,
4748
deps = ALL_SCHEMA_DEPS + [
4849
"//packages/angular_devkit/core",
4950
"//packages/angular_devkit/schematics",

0 commit comments

Comments
 (0)