Skip to content

Commit d827e84

Browse files
alan-agius4clydin
authored andcommitted
test: re-enable i18n app-shell tests
No reason for this to be kept disabled since the missing functionality has been now added.
1 parent dc544d9 commit d827e84

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

tests/legacy-cli/e2e/tests/i18n/ivy-localize-app-shell.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { getGlobalVariable } from '../../utils/env';
22
import {
33
appendToFile,
44
copyFile,
5-
expectFileToExist,
65
expectFileToMatch,
76
replaceInFile,
87
writeFile,
@@ -15,10 +14,6 @@ import { readNgVersion } from '../../utils/version';
1514
const snapshots = require('../../ng-snapshot/package.json');
1615

1716
export default async function () {
18-
// TEMP: disable pending i18n updates
19-
// TODO: when re-enabling, use setupI18nConfig and helpers like other i18n tests.
20-
return;
21-
2217
const isSnapshotBuild = getGlobalVariable('argv')['ng-snapshots'];
2318

2419
await updateJsonFile('package.json', (packageJson) => {
@@ -79,7 +74,6 @@ export default async function () {
7974
serverOptions.localize = true;
8075

8176
// Add locale definitions to the project
82-
// tslint:disable-next-line: no-any
8377
const i18n: Record<string, any> = (appProject.i18n = { locales: {} });
8478
for (const { lang } of langTranslations) {
8579
if (lang == 'en-US') {
@@ -105,7 +99,6 @@ export default async function () {
10599

106100
// Extract the translation messages and copy them for each language.
107101
await ng('extract-i18n', '--output-path=src/locale');
108-
await expectFileToExist('src/locale/messages.xlf');
109102
await expectFileToMatch('src/locale/messages.xlf', `source-language="en-US"`);
110103
await expectFileToMatch('src/locale/messages.xlf', `An introduction header for this sample`);
111104

@@ -131,7 +124,6 @@ export default async function () {
131124

132125
// Build each locale and verify the output.
133126
await ng('run', 'test-project:app-shell');
134-
135127
for (const { lang, translation } of langTranslations) {
136128
await expectFileToMatch(`${browserBaseDir}/${lang}/index.html`, translation);
137129
}

0 commit comments

Comments
 (0)