refactor(@schematics/angular): remove unneeded initial library service generation

The `library` schematic will now longer generate an empty Angular service
with the name of the library. Using only the name would generate a file
name conflict with the component now that the type suffix is no longer
used by default. Additionally, services tend to be specific to a particular
behavior and/or functionality and are named as such. A generically named
empty service will typically be deleted or renamed.

Author: clydin

packages/schematics/angular/library/files/src/__entryFile__.ts.template

@@ -2,6 +2,5 @@
  * Public API Surface of <%= dasherize(name) %>
  */
 
-export * from './lib/<%= dasherize(name) %>.service';
 export * from './lib/<%= dasherize(name) %>';<% if (!standalone) { %>
 export * from './lib/<%= dasherize(name) %>.module';<% } %>

packages/schematics/angular/library/index.ts

@@ -185,12 +185,6 @@ export default function (options: LibraryOptions): Rule {
         standalone: options.standalone,
         project: packageName,
       }),
-      schematic('service', {
-        name: options.name,
-        flat: true,
-        path: sourceDir,
-        project: packageName,
-      }),
       (_tree: Tree, context: SchematicContext) => {
         if (!options.skipPackageJson && !options.skipInstall) {
           context.addTask(new NodePackageInstallTask());

packages/schematics/angular/library/index_spec.ts

@@ -57,8 +57,6 @@ describe('Library Schematic', () => {
         '/projects/foo/src/my-index.ts',
         '/projects/foo/src/lib/foo.spec.ts',
         '/projects/foo/src/lib/foo.ts',
-        '/projects/foo/src/lib/foo.service.spec.ts',
-        '/projects/foo/src/lib/foo.service.ts',
       ]),
     );
   });
@@ -102,8 +100,6 @@ describe('Library Schematic', () => {
           '/some/other/directory/bar/src/my-index.ts',
           '/some/other/directory/bar/src/lib/foo.spec.ts',
           '/some/other/directory/bar/src/lib/foo.ts',
-          '/some/other/directory/bar/src/lib/foo.service.spec.ts',
-          '/some/other/directory/bar/src/lib/foo.service.ts',
         ]),
       );
     });
@@ -207,10 +203,8 @@ describe('Library Schematic', () => {
     const project = config.projects.pascalCasedName;
     expect(project).toBeDefined();
     expect(project.root).toEqual('projects/pascal-cased-name');
-    const svcContent = tree.readContent(
-      '/projects/pascal-cased-name/src/lib/pascal-cased-name.service.ts',
-    );
-    expect(svcContent).toMatch(/providedIn: 'root'/);
+    const svcContent = tree.readContent('/projects/pascal-cased-name/src/lib/pascal-cased-name.ts');
+    expect(svcContent).toContain('@Component');
   });
 
   describe(`update package.json`, () => {
@@ -320,7 +314,6 @@ describe('Library Schematic', () => {
 
     const pkgJsonPath = '/projects/myscope/mylib/package.json';
     expect(tree.files).toContain(pkgJsonPath);
-    expect(tree.files).toContain('/projects/myscope/mylib/src/lib/mylib.service.ts');
     expect(tree.files).toContain('/projects/myscope/mylib/src/lib/mylib.ts');
 
     const pkgJson = JSON.parse(tree.readContent(pkgJsonPath));
@@ -431,8 +424,6 @@ describe('Library Schematic', () => {
           '/projects/foo/src/lib/foo.module.ts',
           '/projects/foo/src/lib/foo.spec.ts',
           '/projects/foo/src/lib/foo.ts',
-          '/projects/foo/src/lib/foo.service.spec.ts',
-          '/projects/foo/src/lib/foo.service.ts',
         ]),
       );
     });