refactor: streamline test runner dependency management using array mapping

This commit simplifies the `getTestRunnerDependencies` implementation and renames it to `addTestRunnerDependencies`.

Author: alan-agius4

packages/schematics/angular/application/index.ts

@@ -23,7 +23,7 @@ import {
   url,
 } from '@angular-devkit/schematics';
 import { Schema as ComponentOptions, Style as ComponentStyle } from '../component/schema';
-import { getTestRunnerDependencies } from '../utility/dependencies';
+import { addTestRunnerDependencies } from '../utility/dependencies';
 import {
   DependencyType,
   ExistingBehavior,
@@ -188,7 +188,7 @@ function addDependenciesToPackageJson(options: ApplicationOptions): Rule {
   }
 
   if (!options.skipTests) {
-    rules.push(...getTestRunnerDependencies(options.testRunner, !!options.skipInstall));
+    rules.push(...addTestRunnerDependencies(options.testRunner, !!options.skipInstall));
   }
 
   return chain(rules);

packages/schematics/angular/library/index.ts

@@ -20,7 +20,7 @@ import {
   url,
 } from '@angular-devkit/schematics';
 import { join } from 'node:path/posix';
-import { getTestRunnerDependencies } from '../utility/dependencies';
+import { addTestRunnerDependencies } from '../utility/dependencies';
 import {
   DependencyType,
   ExistingBehavior,
@@ -79,7 +79,7 @@ function addDependenciesToPackageJson({ skipInstall, testRunner }: LibraryOption
         install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
       }),
     ),
-    ...getTestRunnerDependencies(testRunner, !!skipInstall),
+    ...addTestRunnerDependencies(testRunner, !!skipInstall),
     addDependency('tslib', latestVersions['tslib'], {
       type: DependencyType.Default,
       existing: ExistingBehavior.Skip,

packages/schematics/angular/utility/dependencies.ts

@@ -82,60 +82,28 @@ export function getPackageJsonDependency(
   return null;
 }
 
-export function getTestRunnerDependencies(
+export function addTestRunnerDependencies(
   testRunner: TestRunner | undefined,
   skipInstall: boolean,
 ): Rule[] {
-  if (testRunner === TestRunner.Vitest) {
-    return [
-      addDependency('vitest', latestVersions['vitest'], {
-        type: DependencyType.Dev,
-        existing: ExistingBehavior.Skip,
-        install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-      }),
-      addDependency('jsdom', latestVersions['jsdom'], {
-        type: DependencyType.Dev,
-        existing: ExistingBehavior.Skip,
-        install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-      }),
-    ];
-  }
+  const dependencies =
+    testRunner === TestRunner.Vitest
+      ? ['vitest', 'jsdom']
+      : [
+          'karma',
+          'karma-chrome-launcher',
+          'karma-coverage',
+          'karma-jasmine',
+          'karma-jasmine-html-reporter',
+          'jasmine-core',
+          '@types/jasmine',
+        ];
 
-  return [
-    addDependency('karma', latestVersions['karma'], {
-      type: DependencyType.Dev,
-      existing: ExistingBehavior.Skip,
-      install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-    }),
-    addDependency('karma-chrome-launcher', latestVersions['karma-chrome-launcher'], {
-      type: DependencyType.Dev,
-      existing: ExistingBehavior.Skip,
-      install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-    }),
-    addDependency('karma-coverage', latestVersions['karma-coverage'], {
-      type: DependencyType.Dev,
-      existing: ExistingBehavior.Skip,
-      install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-    }),
-    addDependency('karma-jasmine', latestVersions['karma-jasmine'], {
-      type: DependencyType.Dev,
-      existing: ExistingBehavior.Skip,
-      install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-    }),
-    addDependency('karma-jasmine-html-reporter', latestVersions['karma-jasmine-html-reporter'], {
-      type: DependencyType.Dev,
-      existing: ExistingBehavior.Skip,
-      install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-    }),
-    addDependency('jasmine-core', latestVersions['jasmine-core'], {
-      type: DependencyType.Dev,
-      existing: ExistingBehavior.Skip,
-      install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
-    }),
-    addDependency('@types/jasmine', latestVersions['@types/jasmine'], {
+  return dependencies.map((name) =>
+    addDependency(name, latestVersions[name], {
       type: DependencyType.Dev,
       existing: ExistingBehavior.Skip,
       install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,
     }),
-  ];
+  );
 }