Skip to content

Commit ee86b6b

Browse files
committed
build: update puppeteer to v23
1 parent 5fad329 commit ee86b6b

File tree

9 files changed

+243
-156
lines changed

9 files changed

+243
-156
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ yarn-error.log*
5454
.husky/_
5555
.bazelrc.user
5656
.eslintcache
57+
.cache/
5758

5859
# Mac OSX Finder files.
5960
**/.DS_Store

.puppeteerrc.cjs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
const { join } = require('path');
2+
3+
/**
4+
* @type {import("puppeteer").Configuration}
5+
*/
6+
module.exports = {
7+
// Changes the cache location for Puppeteer.
8+
cacheDirectory: join(__dirname, '.cache', 'puppeteer'),
9+
};

BUILD.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,11 @@ copy_to_bin(
5959
],
6060
)
6161

62+
copy_to_bin(
63+
name = "puppeteer_browsers",
64+
srcs = [".puppeteerrc.cjs"] + glob([".cache/puppeteer/**"]),
65+
)
66+
6267
# Detect if the build is running under --stamp
6368
config_setting(
6469
name = "stamp",

WORKSPACE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ yarn_install(
139139
"//:patches/@angular+bazel+19.1.0-next.4.patch",
140140
"//:patches/@bazel+concatjs+5.8.1.patch",
141141
"//:patches/@bazel+jasmine+5.8.1.patch",
142+
"//:.puppeteerrc.cjs",
142143
],
143144
# Currently disabled due to:
144145
# 1. Missing Windows support currently.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@
176176
"postcss-loader": "8.1.1",
177177
"prettier": "^3.0.0",
178178
"protractor": "~7.0.0",
179-
"puppeteer": "18.2.1",
179+
"puppeteer": "23.1.0",
180180
"quicktype-core": "23.0.171",
181181
"resolve-url-loader": "5.0.0",
182182
"rollup": "4.31.0",

packages/angular/build/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ describeServeBuilder(
162162
// See: https://github.com/angular/angular-cli/pull/17624
163163
// eslint-disable-next-line max-len
164164
// executablePath: '/Users/<USERNAME>/git/angular-cli/node_modules/puppeteer/.local-chromium/mac-818858/chrome-mac/Chromium.app/Contents/MacOS/Chromium',
165-
ignoreHTTPSErrors: true,
165+
acceptInsecureCerts: true,
166166
args: ['--no-sandbox', '--disable-gpu'],
167167
});
168168
});

packages/angular_devkit/build_angular/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ LARGE_SPECS = {
411411
jasmine_node_test(
412412
name = "build_angular_" + spec + "_test",
413413
size = LARGE_SPECS[spec].get("size", "medium"),
414+
data = ["//:puppeteer_browsers"],
414415
flaky = LARGE_SPECS[spec].get("flaky", False),
415416
shard_count = LARGE_SPECS[spec].get("shards", 2),
416417
# These tests are resource intensive and should not be over-parallized as they will

packages/angular_devkit/build_angular/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ describeServeBuilder(
162162
// See: https://github.com/angular/angular-cli/pull/17624
163163
// eslint-disable-next-line max-len
164164
// executablePath: '/Users/<USERNAME>/git/angular-cli/node_modules/puppeteer/.local-chromium/mac-818858/chrome-mac/Chromium.app/Contents/MacOS/Chromium',
165-
ignoreHTTPSErrors: true,
165+
acceptInsecureCerts: true,
166166
args: ['--no-sandbox', '--disable-gpu'],
167167
});
168168
});

0 commit comments

Comments
 (0)