From bd162bdcc97b3ab1655f0740e313b5994415f03a Mon Sep 17 00:00:00 2001
From: Charles Lyding <19598772+clydin@users.noreply.github.com>
Date: Fri, 1 Nov 2024 10:57:17 -0400
Subject: [PATCH] fix(@angular/cli): recommend optional application update
 migration during v19 update

The optional application builder migration will now default to enabled and
recommended during the update process (`ng update`) for v19. The migration
is still optional and can be unselected if preferred when updating.
---
 packages/angular/cli/src/commands/update/cli.ts                 | 2 ++
 packages/angular/cli/src/utilities/prompt.ts                    | 2 +-
 .../schematics/angular/migrations/migration-collection.json     | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/angular/cli/src/commands/update/cli.ts b/packages/angular/cli/src/commands/update/cli.ts
index 19a9f080d8ef..7ffc7d6c212a 100644
--- a/packages/angular/cli/src/commands/update/cli.ts
+++ b/packages/angular/cli/src/commands/update/cli.ts
@@ -68,6 +68,7 @@ interface MigrationSchematicDescription
   extends SchematicDescription<FileSystemCollectionDescription, FileSystemSchematicDescription> {
   version?: string;
   optional?: boolean;
+  recommended?: boolean;
   documentation?: string;
 }
 
@@ -1138,6 +1139,7 @@ export default class UpdateCommandModule extends CommandModule<UpdateCommandArgs
         return {
           name: `[${colors.white(migration.name)}] ${title}${documentation ? ` (${documentation})` : ''}`,
           value: migration.name,
+          checked: migration.recommended,
         };
       }),
       null,
diff --git a/packages/angular/cli/src/utilities/prompt.ts b/packages/angular/cli/src/utilities/prompt.ts
index 3d4e8c67ce09..c1cd8eba0c3c 100644
--- a/packages/angular/cli/src/utilities/prompt.ts
+++ b/packages/angular/cli/src/utilities/prompt.ts
@@ -54,7 +54,7 @@ export async function askQuestion(
 
 export async function askChoices(
   message: string,
-  choices: { name: string; value: string }[],
+  choices: { name: string; value: string; checked?: boolean }[],
   noTTYResponse: string[] | null,
 ): Promise<string[] | null> {
   if (!isTTY()) {
diff --git a/packages/schematics/angular/migrations/migration-collection.json b/packages/schematics/angular/migrations/migration-collection.json
index 6b1647e5d602..d5306f9ca76a 100644
--- a/packages/schematics/angular/migrations/migration-collection.json
+++ b/packages/schematics/angular/migrations/migration-collection.json
@@ -5,6 +5,7 @@
       "factory": "./use-application-builder/migration",
       "description": "Migrate application projects to the new build system. Application projects that are using the '@angular-devkit/build-angular' package's 'browser' and/or 'browser-esbuild' builders will be migrated to use the new 'application' builder. You can read more about this, including known issues and limitations, here: https://angular.dev/tools/cli/build-system-migration",
       "optional": true,
+      "recommended": true,
       "documentation": "tools/cli/build-system-migration"
     },
     "update-workspace-config": {