feat(@angular/cli): allow for custom sha hash algos in SRI #28977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
angular-robot
bot
added
detected: feature
wkaskie
force-pushed
the
wkaskie/CustomSriHash
branch
from
b995055 to
d9d6155
Compare
wkaskie
force-pushed
the
wkaskie/CustomSriHash
branch
from
d9d6155 to
abd249a
Compare
|
Thanks for your contribution. |
|
@alan-agius4 I was AFK for the holiday weekend. I responded to the issue with more details. I've been asked to "just fork" the repository and use a custom build, but you know as well as I do what a horrible idea that is! Thanks for the review! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, enabling SRI will default to the sha384 algorithm. This is not always available on the server (s3 supports up to sha256, for example.)
Issue Number: 28946
What is the new behavior?
The modifications expose a new configuration property to match that of the webpack-subresource-integrity
hashFuncNameswhich accepts an array of strings, leveraging the highest available. This allows users to set sha256 or sha512.Does this PR introduce a breaking change?
Other information