From b8f0c0e1333559302a141e91420e4f7d5e369808 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98ystein=20Amundsen?= Date: Tue, 8 Apr 2025 08:20:35 +0200 Subject: [PATCH] fix(@angular/build): Must respect externalDependencies --- .../build/src/builders/application/execute-build.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/angular/build/src/builders/application/execute-build.ts b/packages/angular/build/src/builders/application/execute-build.ts index 72a07d8b8307..3aee57a0c1a3 100644 --- a/packages/angular/build/src/builders/application/execute-build.ts +++ b/packages/angular/build/src/builders/application/execute-build.ts @@ -171,7 +171,6 @@ export async function executeBuild( // This means all paths within the @foo/bar package are also marked as external. const exclusionsPrefixes = externalConfiguration.map((exclusion) => exclusion + '/'); const exclusions = new Set(externalConfiguration); - const explicitExternal = new Set(); const isExplicitExternal = (dep: string): boolean => { if (exclusions.has(dep)) { @@ -189,23 +188,19 @@ export async function executeBuild( const implicitBrowser: string[] = []; for (const dep of browser) { - if (isExplicitExternal(dep)) { - explicitExternal.add(dep); - } else { + if (!isExplicitExternal(dep)) { implicitBrowser.push(dep); } } const implicitServer: string[] = []; for (const dep of server) { - if (isExplicitExternal(dep)) { - explicitExternal.add(dep); - } else { + if (!isExplicitExternal(dep)) { implicitServer.push(dep); } } - executionResult.setExternalMetadata(implicitBrowser, implicitServer, [...explicitExternal]); + executionResult.setExternalMetadata(implicitBrowser, implicitServer, [...exclusions]); } const { metafile, initialFiles, outputFiles } = bundlingResult;