4633562 fix(@angular/build): disable dev-server websocket when live reload is disabled

Author: Angular Builds

package.json

@@ -1,16 +1,16 @@
 {
   "name": "@angular-devkit/build-angular",
-  "version": "19.1.0-next.0+sha-ae9dfdd",
+  "version": "19.1.0-next.0+sha-4633562",
   "description": "Angular Webpack Build Facade",
   "main": "src/index.js",
   "typings": "src/index.d.ts",
   "builders": "builders.json",
   "dependencies": {
     "@ampproject/remapping": "2.3.0",
-    "@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#ae9dfdd",
-    "@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#ae9dfdd",
-    "@angular-devkit/core": "github:angular/angular-devkit-core-builds#ae9dfdd",
-    "@angular/build": "github:angular/angular-build-builds#ae9dfdd",
+    "@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#4633562",
+    "@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#4633562",
+    "@angular-devkit/core": "github:angular/angular-devkit-core-builds#4633562",
+    "@angular/build": "github:angular/angular-build-builds#4633562",
     "@babel/core": "7.26.0",
     "@babel/generator": "7.26.2",
     "@babel/helper-annotate-as-pure": "7.25.9",
@@ -21,7 +21,7 @@
     "@babel/preset-env": "7.26.0",
     "@babel/runtime": "7.26.0",
     "@discoveryjs/json-ext": "0.6.3",
-    "@ngtools/webpack": "github:angular/ngtools-webpack-builds#ae9dfdd",
+    "@ngtools/webpack": "github:angular/ngtools-webpack-builds#4633562",
     "@vitejs/plugin-basic-ssl": "1.1.0",
     "ansi-colors": "4.1.3",
     "autoprefixer": "10.4.20",
@@ -70,7 +70,7 @@
     "@angular/localize": "^19.0.0-next.0",
     "@angular/platform-server": "^19.0.0-next.0",
     "@angular/service-worker": "^19.0.0-next.0",
-    "@angular/ssr": "github:angular/angular-ssr-builds#ae9dfdd",
+    "@angular/ssr": "github:angular/angular-ssr-builds#4633562",
     "@web/test-runner": "^0.19.0",
     "browser-sync": "^3.0.2",
     "jest": "^29.5.0",
@@ -91,7 +91,7 @@
     "@angular/service-worker": {
       "optional": true
     },
-    "@angular/ssr": "github:angular/angular-ssr-builds#ae9dfdd",
+    "@angular/ssr": "github:angular/angular-ssr-builds#4633562",
     "@web/test-runner": {
       "optional": true
     },

src/builders/dev-server/builder.js

@@ -72,6 +72,8 @@ function execute(options, context, transforms = {}, extensions) {
             if (options.disableHostCheck) {
                 context.logger.warn(`The "disableHostCheck" option will not be used because it is not supported by the "${builderName}" builder.`);
             }
+            // New build system defaults hmr option to the value of liveReload
+            normalizedOptions.hmr ??= normalizedOptions.liveReload;
             return (0, rxjs_1.defer)(() => Promise.all([Promise.resolve().then(() => __importStar(require('@angular/build/private'))), Promise.resolve().then(() => __importStar(require('../browser-esbuild')))])).pipe((0, rxjs_1.switchMap)(([{ serveWithVite, buildApplicationInternal }, { convertBrowserOptions }]) => serveWithVite(normalizedOptions, builderName, (options, context, codePlugins) => {
                 return builderName === '@angular-devkit/build-angular:browser-esbuild'
                     ? // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -91,6 +93,8 @@ function execute(options, context, transforms = {}, extensions) {
         if (extensions?.middleware?.length) {
             throw new Error('Only the "application" and "browser-esbuild" builders support middleware.');
         }
+        // Webpack based build systems default to false for hmr option
+        normalizedOptions.hmr ??= false;
         // Use Webpack for all other browser targets
         return (0, rxjs_1.defer)(() => Promise.resolve().then(() => __importStar(require('./webpack-server')))).pipe((0, rxjs_1.switchMap)(({ serveWebpackBrowser }) => serveWebpackBrowser(normalizedOptions, builderName, context, transforms)));
     }));

src/builders/dev-server/options.d.ts

@@ -26,7 +26,7 @@ export declare function normalizeOptions(context: BuilderContext, projectName: s
     open: boolean | undefined;
     verbose: boolean | undefined;
     watch: boolean | undefined;
-    liveReload: boolean | undefined;
+    liveReload: boolean;
     hmr: boolean | undefined;
     headers: {
         [key: string]: string;

src/builders/dev-server/options.js

@@ -85,7 +85,7 @@ async function normalizeOptions(context, projectName, options) {
         open,
         verbose,
         watch,
-        liveReload,
+        liveReload: !!liveReload,
         hmr,
         headers,
         workspaceRoot,

src/builders/dev-server/schema.json

@@ -84,8 +84,7 @@
     },
     "hmr": {
       "type": "boolean",
-      "description": "Enable hot module replacement.",
-      "default": false
+      "description": "Enable hot module replacement."
     },
     "watch": {
       "type": "boolean",

src/utils/normalize-cache.js

@@ -10,7 +10,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.normalizeCacheOptions = normalizeCacheOptions;
 const node_path_1 = require("node:path");
 /** Version placeholder is replaced during the build process with actual package version */
-const VERSION = '19.1.0-next.0+sha-ae9dfdd';
+const VERSION = '19.1.0-next.0+sha-4633562';
 function hasCacheMetadata(value) {
     return (!!value &&
         typeof value === 'object' &&

uniqueId

@@ -1 +1 @@
-Tue Nov 05 2024 09:35:59 GMT+0000 (Coordinated Universal Time)
+Tue Nov 05 2024 10:04:17 GMT+0000 (Coordinated Universal Time)