Skip to content

Commit 52f97e0

Browse files
author
Angular Builds
committed
73c2437 fix(@angular-devkit/schematics-cli): prevent bypassing select/checkbox prompts on validation failure
1 parent 8eb0b82 commit 52f97e0

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

bin/schematics.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,12 @@ function _createPromptProvider() {
105105
answers[definition.id] = await (definition.multiselect ? prompts.checkbox : prompts.select)({
106106
message: definition.message,
107107
default: definition.default,
108+
validate: (values) => {
109+
if (!definition.validator) {
110+
return true;
111+
}
112+
return definition.validator(Object.values(values).map(({ value }) => value));
113+
},
108114
choices: definition.items.map((item) => typeof item == 'string'
109115
? {
110116
name: item,

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@angular-devkit/schematics-cli",
3-
"version": "18.3.0-next.0+sha-ce11a39",
3+
"version": "18.3.0-next.0+sha-73c2437",
44
"description": "Angular Schematics - CLI",
55
"homepage": "https://github.com/angular/angular-cli",
66
"bin": {
@@ -21,8 +21,8 @@
2121
],
2222
"schematics": "./collection.json",
2323
"dependencies": {
24-
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#ce11a39",
25-
"@angular-devkit/schematics": "github:angular/angular-devkit-schematics-builds#ce11a39",
24+
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#73c2437",
25+
"@angular-devkit/schematics": "github:angular/angular-devkit-schematics-builds#73c2437",
2626
"@inquirer/prompts": "5.3.8",
2727
"ansi-colors": "4.1.3",
2828
"symbol-observable": "4.0.0",

uniqueId

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Fri Aug 09 2024 12:20:56 GMT+0000 (Coordinated Universal Time)
1+
Mon Aug 12 2024 13:47:07 GMT+0000 (Coordinated Universal Time)

0 commit comments

Comments
 (0)