Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 3db8642

Browse files
filipesilvanaomiblack
authored andcommitted
fix(quickstart): add styles.css to js quickstart
Fix #1684 While looking at this, I saw that plunkers were getting some unintended unit testing files and added them to the default plunker builder ignore.
1 parent 61c85a9 commit 3db8642

File tree

3 files changed

+35
-4
lines changed

3 files changed

+35
-4
lines changed
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
/* #docregion */
2+
h1 {
3+
color: #369;
4+
font-family: Arial, Helvetica, sans-serif;
5+
font-size: 250%;
6+
}
7+
body {
8+
margin: 2em;
9+
}
10+
11+
/*
12+
* See https://github.com/angular/angular.io/blob/master/public/docs/_examples/styles.css
13+
* for the full set of master styles used by the documentation samples
14+
*/

public/docs/js/latest/quickstart.jade

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ figure.image-display
3131
.file app.component.js
3232
.file main.js
3333
.file index.html
34-
.file license.md
34+
.file styles.css
3535
:marked
36-
Functionally, it's an `index.html` and two JavaScript files in an `app/` folder.
36+
Functionally, it's an `index.html`, `styles.css` and two JavaScript files in an `app/` folder.
3737
We can handle that!
3838

3939
Of course we won't build many apps that only run in plunker.
@@ -43,6 +43,7 @@ figure.image-display
4343
1. Write the Angular root component for our app
4444
1. Bootstrap it to take control of the main web page
4545
1. Write the main page (`index.html`)
46+
1. Add some CSS (`styles.css`)
4647

4748
.l-sub-section
4849
:marked
@@ -257,6 +258,16 @@ code-example(format="").
257258
metadata, finds the `my-app` selector, locates an element tag named `my-app`,
258259
and loads our application between those tags.
259260

261+
:marked
262+
### Add some style
263+
Styles aren't essential but they're nice, and `index.html` assumes we have
264+
a stylesheet called `styles.css`.
265+
266+
Create a `styles.css` file in the *#{_indexHtmlDir}* folder and start styling, perhaps with the minimal
267+
styles shown below. For the full set of master styles used by the documentation samples,
268+
see [styles.css](https://github.com/angular/angular.io/blob/master/public/docs/_examples/styles.css).
269+
+makeExample('quickstart/js/styles.1.css', null, 'styles.css')(format=".")
270+
260271
.l-main-section
261272
:marked
262273
## Run!
@@ -306,15 +317,17 @@ figure.image-display
306317
.file main.js
307318
.file index.html
308319
.file package.json
320+
.file styles.css
309321
:marked
310322
And here are the files:
311323
+makeTabs(`
312324
quickstart/js/app/app.component.js,
313325
quickstart/js/app/main.js,
314326
quickstart/js/index.html,
315-
quickstart/js/package.1.json
327+
quickstart/js/package.1.json,
328+
quickstart/js/styles.1.css
316329
`,null,
317-
`app/app.component.js, app/main.js, index.html,package.json`)
330+
`app/app.component.js, app/main.js, index.html, package.json, styles.css`)
318331
:marked
319332

320333
.l-main-section

tools/plunker-builder/plunkerBuilder.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,10 @@ function initConfigAndCollectFileNames(configFileName) {
143143
'!**/tslint.json',
144144
'!**/.editorconfig',
145145
'!**/systemjs.config.js',
146+
'!**/wallaby.js',
147+
'!**/karma-test-shim.js',
148+
'!**/karma.conf.js',
149+
'!**/spec.js'
146150
];
147151
Array.prototype.push.apply(gpaths, defaultExcludes);
148152

0 commit comments

Comments
 (0)