fix(deploy): deploying with service account (#3396)

* fix(deploy): deploying with service account

Deploying with service account was not possible, becouse no checks were made for
GOOGLE_APPLICATION_CREDENTIALS env variable

Fixes #3260

* fix(deploy): not activated gcloud service account

Service account was not activated before deploying

Fixes #3260

* conflicts

* yarn lock

---------

Co-authored-by: Zalán Horváth <[email protected]>

Author: davideast

src/schematics/deploy/actions.ts

@@ -88,7 +88,7 @@ const deployToHosting = async (
       type: 'confirm',
       name: 'deployProject',
       message: 'Would you like to deploy your application to Firebase Hosting?'
-    });
+    }) as { deployProject: boolean };
 
     if (!deployProject) { return; }
 
@@ -253,11 +253,11 @@ export const deployToFunction = async (
       projectRoot: workspaceRoot,
     });
 
-    const { deployProject} = await inquirer.prompt({
+    const { deployProject } = await inquirer.prompt({
       type: 'confirm',
       name: 'deployProject',
       message: 'Would you like to deploy your application to Firebase Hosting & Cloud Functions?'
-    });
+    }) as { deployProject: boolean };
 
     if (!deployProject) { return; }
   }
@@ -390,52 +390,50 @@ export default async function deploy(
   options: DeployBuilderOptions,
   firebaseToken?: string,
 ) {
-  if (!firebaseToken) {
+  if (!firebaseToken && !process.env.GOOGLE_APPLICATION_CREDENTIALS) {
     await firebaseTools.login();
     const user = await firebaseTools.login({ projectRoot: context.workspaceRoot });
     console.log(`Logged into Firebase as ${user.email}.`);
   }
 
-  if (options.version && options.version >= 2) {
-    if (lt(firebaseTools.cli.version(), '12.2.0')) {
-      throw new SchematicsException('firebase-tools version 12.2+ is required.');
-    }
-    process.env.FIREBASE_FRAMEWORK_BUILD_TARGET = (prerenderBuildTarget || serverBuildTarget || staticBuildTarget).name;
-  } else {
-    if (prerenderBuildTarget) {
-
-      const run = await context.scheduleTarget(
-        targetFromTargetString(prerenderBuildTarget.name),
-        prerenderBuildTarget.options
-      );
-      await run.result;
+  if (!firebaseToken && process.env.GOOGLE_APPLICATION_CREDENTIALS) {
+    await spawnAsync(`gcloud auth activate-service-account --key-file ${process.env.GOOGLE_APPLICATION_CREDENTIALS}`);
+    console.log(`Using Google Application Credentials.`);
+  }
 
-    } else {
+  if (prerenderBuildTarget) {
+    const run = await context.scheduleTarget(
+      targetFromTargetString(prerenderBuildTarget.name),
+      prerenderBuildTarget.options
+    );
+    await run.result;
 
-      if (!context.target) {
-        throw new Error('Cannot execute the build target');
-      }
+  } else {
 
-      context.logger.info(`📦 Building "${context.target.project}"`);
+    if (!context.target) {
+      throw new Error('Cannot execute the build target');
+    }
 
-      const builders = [
-        context.scheduleTarget(
-          targetFromTargetString(staticBuildTarget.name),
-          staticBuildTarget.options
-        ).then(run => run.result)
-      ];
+    context.logger.info(`📦 Building "${context.target.project}"`);
 
-      if (serverBuildTarget) {
-        builders.push(context.scheduleTarget(
-          targetFromTargetString(serverBuildTarget.name),
-          serverBuildTarget.options
-        ).then(run => run.result));
-      }
+    const builders = [
+      context.scheduleTarget(
+        targetFromTargetString(staticBuildTarget.name),
+        staticBuildTarget.options
+      ).then(run => run.result)
+    ];
 
-      await Promise.all(builders);
+    if (serverBuildTarget) {
+      builders.push(context.scheduleTarget(
+        targetFromTargetString(serverBuildTarget.name),
+        serverBuildTarget.options
+      ).then(run => run.result));
     }
+
+    await Promise.all(builders);
   }
 
+
   try {
     await firebaseTools.use(firebaseProject, {
       project: firebaseProject,