Skip to content

Commit 9cbc59b

Browse files
cartantdavideast
authored andcommitted
fix(database): removed unused query option
The docs mention that lists should be used for querying/filtering and the query option is ignored by the object factory. The query option should be removed so that it is no longer suggested by TypeScript-based tools, etc. Closes #706
1 parent b46eba6 commit 9cbc59b

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/database/firebase_object_factory.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@ import { Observer } from 'rxjs/Observer';
33
import { observeOn } from 'rxjs/operator/observeOn';
44
import * as firebase from 'firebase';
55
import * as utils from '../utils';
6-
import { Query } from '../interfaces';
7-
import { observeQuery } from './query_observable';
86
import { FirebaseObjectFactoryOpts } from '../interfaces';
97

108
export function FirebaseObjectFactory (
119
absoluteUrlOrDbRef: string | firebase.database.Reference,
12-
{ preserveSnapshot, query }: FirebaseObjectFactoryOpts = {}): FirebaseObjectObservable<any> {
10+
{ preserveSnapshot }: FirebaseObjectFactoryOpts = {}): FirebaseObjectObservable<any> {
1311

1412
let ref: firebase.database.Reference;
1513

src/interfaces.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ export interface FirebaseListFactoryOpts {
6565

6666
export interface FirebaseObjectFactoryOpts {
6767
preserveSnapshot?: boolean;
68-
query?: Query
6968
}
7069

7170

@@ -87,4 +86,4 @@ export enum QueryOptions {
8786
EndAt
8887
}
8988

90-
export type Primitive = number | string | boolean;
89+
export type Primitive = number | string | boolean;

0 commit comments

Comments
 (0)