Merge pull request #2431 from angular/fix-lint

chore(lint): Fix lint errors + Run lint pre-commit and In Travis

Author: NothingEverHappens

.travis.yml

@@ -15,4 +15,4 @@ branches:
 
 install: yarn
 
-script: yarn build && yarn test:all
+script: yarn build && yarn test:all && yarn lint

package.json

@@ -16,6 +16,11 @@
     "build": "tsc tools/build.ts; node ./tools/build.js",
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s -r 1"
   },
+  "husky": {
+    "hooks": {
+      "pre-commit": "npm run lint"
+    }
+  },
   "schematics": "./dist/packages-dist/collection.json",
   "builders": "./dist/packages-dist/builders.json",
   "keywords": [
@@ -49,6 +54,7 @@
     "firebase-tools": "^8.0.0",
     "fs-extra": "^8.0.1",
     "fuzzy": "^0.1.3",
+    "husky": "^4.2.5",
     "inquirer": "^6.2.2",
     "inquirer-autocomplete-prompt": "^1.0.1",
     "rxfire": "^3.9.7",

sample/server.ts

@@ -9,8 +9,10 @@ import { APP_BASE_HREF } from '@angular/common';
 import { existsSync } from 'fs';
 
 // Polyfill XMLHttpRequest and WS for Firebase
-global['XMLHttpRequest'] = require("xhr2");
-global['WebSocket'] = require("ws");
+/* tslint:disable:no-string-literal */
+global['XMLHttpRequest'] = require('xhr2');
+global['WebSocket'] = require('ws');
+/* tslint:enable:no-string-literal */
 
 // The Express app is exported so that it can be used by serverless Functions.
 export function app() {

sample/src/app/app-routing.module.ts

@@ -1,5 +1,5 @@
 import { NgModule } from '@angular/core';
-import { Routes, RouterModule } from '@angular/router';
+import { RouterModule, Routes } from '@angular/router';
 
 
 const routes: Routes = [];

sample/src/app/app.component.spec.ts

@@ -1,4 +1,4 @@
-import { TestBed, async } from '@angular/core/testing';
+import { async, TestBed } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
 import { AppComponent } from './app.component';
 

sample/src/app/app.component.ts

@@ -1,4 +1,4 @@
-import { Component, ApplicationRef } from '@angular/core';
+import { ApplicationRef, Component } from '@angular/core';
 import { FirebaseApp } from '@angular/fire';
 
 @Component({

sample/src/app/app.module.ts

@@ -1,5 +1,5 @@
 import { BrowserModule, BrowserTransferStateModule } from '@angular/platform-browser';
-import { NgModule, isDevMode } from '@angular/core';
+import { isDevMode, NgModule } from '@angular/core';
 
 import { AppRoutingModule } from './app-routing.module';
 import { AppComponent } from './app.component';
@@ -9,7 +9,12 @@ import { environment } from '../environments/environment';
 import { AngularFireModule } from '@angular/fire';
 import { AngularFireStorageModule } from '@angular/fire/storage';
 
-import { AngularFireAnalyticsModule, UserTrackingService, ScreenTrackingService, DEBUG_MODE as ANALYTICS_DEBUG_MODE } from '@angular/fire/analytics';
+import {
+  AngularFireAnalyticsModule,
+  DEBUG_MODE as ANALYTICS_DEBUG_MODE,
+  ScreenTrackingService,
+  UserTrackingService
+} from '@angular/fire/analytics';
 
 import { FirestoreComponent } from './firestore/firestore.component';
 
@@ -28,7 +33,7 @@ import { RemoteConfigComponent } from './remote-config/remote-config.component';
 const shouldUseEmulator = () => false;
 
 @NgModule({
-  declarations: [ AppComponent, StorageComponent, FirestoreComponent, DatabaseComponent, RemoteConfigComponent ],
+  declarations: [AppComponent, StorageComponent, FirestoreComponent, DatabaseComponent, RemoteConfigComponent],
   imports: [
     BrowserModule.withServerTransition({ appId: 'serverApp' }),
     BrowserTransferStateModule,
@@ -50,12 +55,19 @@ const shouldUseEmulator = () => false;
     UserTrackingService,
     ScreenTrackingService,
     PerformanceMonitoringService,
-    { provide: ANALYTICS_DEBUG_MODE,   useFactory: () => isDevMode() },
-    { provide: DATABASE_URL,           useFactory: () => shouldUseEmulator() ? `http://localhost:9000?ns=${environment.firebase.projectId}` : undefined },
-    { provide: FIRESTORE_SETTINGS,     useFactory: () => shouldUseEmulator() ? { host: 'localhost:8080', ssl: false } : {} },
-    { provide: FUNCTIONS_ORIGIN,       useFactory: () => shouldUseEmulator() ? 'http://localhost:9999' : undefined },
+    {
+      provide: ANALYTICS_DEBUG_MODE,
+      useFactory: () => isDevMode()
+    },
+    {
+      provide: DATABASE_URL,
+      useFactory: () => shouldUseEmulator() ? `http://localhost:9000?ns=${environment.firebase.projectId}` : undefined
+    },
+    { provide: FIRESTORE_SETTINGS, useFactory: () => shouldUseEmulator() ? { host: 'localhost:8080', ssl: false } : {} },
+    { provide: FUNCTIONS_ORIGIN, useFactory: () => shouldUseEmulator() ? 'http://localhost:9999' : undefined },
     { provide: REMOTE_CONFIG_SETTINGS, useFactory: () => isDevMode() ? { minimumFetchIntervalMillis: 10_000 } : {} }
   ],
-  bootstrap: [ AppComponent ]
+  bootstrap: [AppComponent]
 })
-export class AppModule { }
+export class AppModule {
+}

sample/src/app/database/database.component.ts

@@ -1,7 +1,7 @@
 import { Component, OnInit } from '@angular/core';
 import { AngularFireDatabase } from '@angular/fire/database';
 import { Observable } from 'rxjs';
-import { TransferState, makeStateKey } from '@angular/platform-browser';
+import { makeStateKey, TransferState } from '@angular/platform-browser';
 import { startWith, tap } from 'rxjs/operators';
 import { trace } from '@angular/fire/performance';
 

sample/src/app/firestore/firestore.component.ts

@@ -1,8 +1,8 @@
 import { Component, OnInit } from '@angular/core';
 import { AngularFirestore } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
-import { tap, startWith } from 'rxjs/operators';
-import { TransferState, makeStateKey } from '@angular/platform-browser';
+import { startWith, tap } from 'rxjs/operators';
+import { makeStateKey, TransferState } from '@angular/platform-browser';
 import { trace } from '@angular/fire/performance';
 
 @Component({

sample/src/app/storage/storage.component.ts

@@ -5,14 +5,15 @@ import { startWith, tap } from 'rxjs/operators';
 import { makeStateKey, TransferState } from '@angular/platform-browser';
 import { trace } from '@angular/fire/performance';
 
-const TRANSPARENT_PNG = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII='
+const TRANSPARENT_PNG
+  = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=';
 
 @Component({
   selector: 'app-storage',
   template: `
     <p>
       Storage!
-      <img [src]="downloadUrl$ | async" width="64" height="64" />
+      <img [src]="downloadUrl$ | async" width="64" height="64"/>
     </p>
   `,
   styles: []