-
Notifications
You must be signed in to change notification settings - Fork 13
Universal support #23
Conversation
Paired with @jteplitz602 to get it working. Closes angular#15
…tantiation issue See angular#22
|
out of the box I see some compilation errors: expected, or missing TSD stuff? |
|
(all works fine, but i'll probably fail on CI unless we explicitly ignore those errors or handle them properly) |
The universal errors should be fixed upstream. The errors about not finding express or firebase modules could be fixed by TSD. I will add a commit with TSD.
I just checked, and the gulp task still exits with 0 even with errors. Running |
See typings/README.md for info on why these are checked in.
|
I have typescript error fixes for |
|
@gdi2290 awesome! I was just looking at the universal repo and saw a lot of activity around TS issues, so I figured it was probably already fixed upstream. @robwormald I added a PR with typings included, as well as some local fixes to make TS happy. |
|
for the |
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the repo should use typings. tsd will be deprecated soon. (you also want to .gitignore typings/ folder. see upgrade commit angular/universal-starter@cfb7b52)
|
merging this, lets deal with typings as a separate PR |
feature(universal) add universal support
No description provided.