Skip to content
This repository was archived by the owner on Feb 9, 2020. It is now read-only.

Commit 02e96cf

Browse files
committed
chore(hint): Upgrade angular-hint to 0.2.0
Angular hint 0.2.0 adds several new features, primarily making angular.hint an event emitter. This commit makes Batarang compatible with the new emitter. Closes #204
1 parent 8799e8e commit 02e96cf

File tree

5 files changed

+1305
-1769
lines changed

5 files changed

+1305
-1769
lines changed

background.js

Lines changed: 31 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,9 @@ function bufferOrForward(message, sender) {
1616
showPageAction(tabId);
1717
}
1818

19-
// TODO: not sure how I feel about special-casing `refresh`
2019
if (message !== 'refresh') {
21-
message = JSON.parse(message);
20+
bufferData(tabId, message);
2221
}
23-
24-
bufferData(tabId, message);
2522
if (devToolsPort) {
2623
devToolsPort.postMessage(message);
2724
}
@@ -38,34 +35,41 @@ function bufferData(tabId, message) {
3835
var tabData = data[tabId],
3936
scope;
4037

41-
if (message.message) {
42-
return tabData.hints.push(message);
38+
var hintables = [
39+
'Controllers',
40+
'general',
41+
'Modules',
42+
'Events'
43+
];
44+
45+
if (hintables.indexOf(message.module) > -1) {
46+
tabData.hints.push(message);
4347
}
4448

45-
if (message.event) {
46-
if (message.event === 'scope:new') {
47-
tabData.scopes[message.child] = {
48-
parent: message.parent,
49-
children: [],
50-
models: {}
51-
};
52-
if (tabData.scopes[message.parent]) {
53-
tabData.scopes[message.parent].children.push(message.child);
54-
}
55-
} else if (message.id && (scope = tabData.scopes[message.id])) {
56-
if (message.event === 'scope:destroy') {
57-
if (scope.parent) {
58-
scope.parent.children.splice(scope.parent.children.indexOf(child), 1);
59-
}
60-
delete scopes[message.id];
61-
} else if (message.event === 'model:change') {
62-
scope.models[message.path] = (typeof message.value === 'undefined') ?
63-
undefined : JSON.parse(message.value);
64-
} else if (message.event === 'scope:link') {
65-
scope.descriptor = message.descriptor;
49+
if (message.event === 'scope:new') {
50+
tabData.scopes[message.data.child] = {
51+
parent: message.data.parent,
52+
children: [],
53+
models: {}
54+
};
55+
if (tabData.scopes[message.data.parent]) {
56+
tabData.scopes[message.data.parent].children.push(message.data.child);
57+
}
58+
} else if (message.data.id && (scope = tabData.scopes[message.data.id])) {
59+
if (message.event === 'scope:destroy') {
60+
if (scope.parent) {
61+
scope.parent.children.splice(scope.parent.children.indexOf(child), 1);
6662
}
63+
delete scopes[message.data.id];
64+
} else if (message.event === 'model:change') {
65+
scope.models[message.data.path] = (typeof message.data.value === 'undefined') ?
66+
undefined : message.data.value;
67+
} else if (message.event === 'scope:link') {
68+
scope.descriptor = message.descriptor;
6769
}
6870
}
71+
72+
// TODO: Handle digest timings
6973
}
7074

7175
// context script –> background

0 commit comments

Comments
 (0)