Skip to content

Commit 04773d5

Browse files
committed
refactor(multiple): underscore register methods for internal usage only
1 parent d7060ea commit 04773d5

File tree

3 files changed

+26
-26
lines changed

3 files changed

+26
-26
lines changed

src/aria/tabs/tabs.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class Tabs {
9696
[...this._unorderedPanels()].map(tabpanel => tabpanel._pattern),
9797
);
9898

99-
register(child: TabList | TabPanel) {
99+
_register(child: TabList | TabPanel) {
100100
if (child instanceof TabList) {
101101
this._tablist.set(child);
102102
}
@@ -107,7 +107,7 @@ export class Tabs {
107107
}
108108
}
109109

110-
deregister(child: TabList | TabPanel) {
110+
_unregister(child: TabList | TabPanel) {
111111
if (child instanceof TabList) {
112112
this._tablist.set(undefined);
113113
}
@@ -240,19 +240,19 @@ export class TabList implements OnInit, OnDestroy {
240240
}
241241

242242
ngOnInit() {
243-
this._tabs.register(this);
243+
this._tabs._register(this);
244244
}
245245

246246
ngOnDestroy() {
247-
this._tabs.deregister(this);
247+
this._tabs._unregister(this);
248248
}
249249

250-
register(child: Tab) {
250+
_register(child: Tab) {
251251
this._unorderedTabs().add(child);
252252
this._unorderedTabs.set(new Set(this._unorderedTabs()));
253253
}
254254

255-
deregister(child: Tab) {
255+
_unregister(child: Tab) {
256256
this._unorderedTabs().delete(child);
257257
this._unorderedTabs.set(new Set(this._unorderedTabs()));
258258
}
@@ -341,11 +341,11 @@ export class Tab implements HasElement, OnInit, OnDestroy {
341341
}
342342

343343
ngOnInit() {
344-
this._tabList.register(this);
344+
this._tabList._register(this);
345345
}
346346

347347
ngOnDestroy() {
348-
this._tabList.deregister(this);
348+
this._tabList._unregister(this);
349349
}
350350
}
351351

@@ -420,11 +420,11 @@ export class TabPanel implements OnInit, OnDestroy {
420420
}
421421

422422
ngOnInit() {
423-
this._Tabs.register(this);
423+
this._Tabs._register(this);
424424
}
425425

426426
ngOnDestroy() {
427-
this._Tabs.deregister(this);
427+
this._Tabs._unregister(this);
428428
}
429429
}
430430

src/aria/toolbar/toolbar.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,15 @@ export class Toolbar<V> {
141141
this._hasBeenFocused.set(true);
142142
}
143143

144-
register(widget: ToolbarWidget<V>) {
144+
_register(widget: ToolbarWidget<V>) {
145145
const widgets = this._widgets();
146146
if (!widgets.has(widget)) {
147147
widgets.add(widget);
148148
this._widgets.set(new Set(widgets));
149149
}
150150
}
151151

152-
unregister(widget: ToolbarWidget<V>) {
152+
_unregister(widget: ToolbarWidget<V>) {
153153
const widgets = this._widgets();
154154
if (widgets.delete(widget)) {
155155
this._widgets.set(new Set(widgets));
@@ -236,11 +236,11 @@ export class ToolbarWidget<V> implements OnInit, OnDestroy {
236236
});
237237

238238
ngOnInit() {
239-
this._toolbar.register(this);
239+
this._toolbar._register(this);
240240
}
241241

242242
ngOnDestroy() {
243-
this._toolbar.unregister(this);
243+
this._toolbar._unregister(this);
244244
}
245245
}
246246

src/aria/tree/tree.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,12 @@ export class Tree<V> {
224224
this._hasFocused.set(true);
225225
}
226226

227-
register(child: TreeItem<V>) {
227+
_register(child: TreeItem<V>) {
228228
this._unorderedItems().add(child);
229229
this._unorderedItems.set(new Set(this._unorderedItems()));
230230
}
231231

232-
unregister(child: TreeItem<V>) {
232+
_unregister(child: TreeItem<V>) {
233233
this._unorderedItems().delete(child);
234234
this._unorderedItems.set(new Set(this._unorderedItems()));
235235
}
@@ -349,8 +349,8 @@ export class TreeItem<V> extends DeferredContentAware implements OnInit, OnDestr
349349
}
350350

351351
ngOnInit() {
352-
this.parent().register(this);
353-
this.tree().register(this);
352+
this.parent()._register(this);
353+
this.tree()._register(this);
354354

355355
const treePattern = computed(() => this.tree()._pattern);
356356
const parentPattern = computed(() => {
@@ -371,15 +371,15 @@ export class TreeItem<V> extends DeferredContentAware implements OnInit, OnDestr
371371
}
372372

373373
ngOnDestroy() {
374-
this.parent().unregister(this);
375-
this.tree().unregister(this);
374+
this.parent()._unregister(this);
375+
this.tree()._unregister(this);
376376
}
377377

378-
register(group: TreeItemGroup<V>) {
378+
_register(group: TreeItemGroup<V>) {
379379
this._group.set(group);
380380
}
381381

382-
unregister() {
382+
_unregister() {
383383
this._group.set(undefined);
384384
}
385385
}
@@ -432,19 +432,19 @@ export class TreeItemGroup<V> implements OnInit, OnDestroy {
432432

433433
ngOnInit() {
434434
this._deferredContent.deferredContentAware.set(this.ownedBy());
435-
this.ownedBy().register(this);
435+
this.ownedBy()._register(this);
436436
}
437437

438438
ngOnDestroy() {
439-
this.ownedBy().unregister();
439+
this.ownedBy()._unregister();
440440
}
441441

442-
register(child: TreeItem<V>) {
442+
_register(child: TreeItem<V>) {
443443
this._unorderedItems().add(child);
444444
this._unorderedItems.set(new Set(this._unorderedItems()));
445445
}
446446

447-
unregister(child: TreeItem<V>) {
447+
_unregister(child: TreeItem<V>) {
448448
this._unorderedItems().delete(child);
449449
this._unorderedItems.set(new Set(this._unorderedItems()));
450450
}

0 commit comments

Comments
 (0)