Rework ng-update to no longer depend on tslint (#16433)

* fix(ng-update): no longer depend on tslint for migration

Reworks `ng update` to no longer depend on tslint for the
migration. TSlint caused various problems:

* No support for HTML templates and stylesheets (workaround was needed)
* Reruns all upgrade lint rules after file has been updated (significant performance issue for projects with a lot of files)
* Recreates the TypeScript program each time a source file has been updated (significant memory pressure for big TypeScript projects, causing OOM exceptions)
* TSLint recursively visits the nodes of all source files for each upgrade lint rule (performance issue)
* TSLint is not guaranteed to be installed in CLI projects. See: angular/angular-cli#14555
* TSLint replacements lead to memory leaks due to the retained TypeScript nodes
* No way to have a *global analysis* phase since lint rules are only able to visit source files.
* No flexibility. i.e.
  * No way to ensure source files are only analyzed a single time
  * No way to implement a progress bar
  * No easy way to add support for HTML templates or stylesheets

* chore: reformat update schematics code with clang-format

Reformats the `ng update` code within the CDK and Material package
with clang-format. This ensures that the update code is consistent.

* docs: update schematic architecture document

Updates the schematic architecture document to reflect the
new state of the `ng update` implementation which no longer
uses `tslint` under the hood.

* perf(ng-update): do not run migration rules if there is no upgrade data

* No longer runs migration rules if there is no upgrade data. Running rules
conditionally is now easy to implement with the new `update-tool`.
* Adds comments for misc rule migrations to show which PR the given misc
migration covers.

* perf(ng-update): only migrate projects referenced in CLI workspace config

Currently `ng update` tries to resolve projects by common TypeScript tsconfig
locations besides looking in the CLI workspace config. This means that projects
which are technically not part of a workspace project are still migrated even
though they don't need to be. Similarly to `angular/angular`, we only migrate
projects explicitly referenced in the `angular.json` workspace configuration.

* refactor(ng-update): better messaging for migration failures

Previously with tslint, we had no way to determine whether there were
any upgrade rules which added rule failures without an automatic migration.

With the `update-tool` we can now conditionally print a better a message
if there were rule failures which need manual developer attention. i.e. we
only print the message that asks the developer to check for any failures in
the terminal output if there were actual rule failures.

Author: devversion

src/cdk/schematics/BUILD.bazel

@@ -26,6 +26,7 @@ ts_library(
     module_name = "@angular/cdk/schematics",
     tsconfig = ":tsconfig.json",
     deps = [
+        "//src/cdk/schematics/update-tool",
         "@npm//@schematics/angular",
         "@npm//@angular-devkit/core",
         "@npm//@angular-devkit/schematics",
@@ -34,7 +35,6 @@ ts_library(
         "@npm//@types/node",
         "@npm//glob",
         "@npm//parse5",
-        "@npm//tslint",
         "@npm//typescript",
         "@npm//chalk",
     ],
@@ -73,12 +73,12 @@ ts_library(
     deps = [
         ":schematics",
         "//src/cdk/schematics/testing",
+        "//src/cdk/schematics/update-tool",
         "@npm//@angular-devkit/schematics",
         "@npm//@schematics/angular",
         "@npm//@types/jasmine",
         "@npm//@types/node",
         "@npm//mock-fs",
-        "@npm//tslint",
         "@npm//typescript",
     ],
 )

src/cdk/schematics/index.ts

@@ -8,3 +8,4 @@
 
 export * from './utils';
 export * from './ng-update/public-api';
+export * from './update-tool/public-api';

src/cdk/schematics/ng-update/data/attribute-selectors.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export interface AttributeSelectorUpgradeData {
   /** The attribute name to replace. */
@@ -17,19 +17,11 @@ export interface AttributeSelectorUpgradeData {
 }
 
 export const attributeSelectors: VersionChanges<AttributeSelectorUpgradeData> = {
-  [TargetVersion.V6]: [
-    {
-      pr: 'https://github.com/angular/components/pull/10257',
-      changes: [
-        {
-          replace: 'cdkPortalHost',
-          replaceWith: 'cdkPortalOutlet'
-        },
-        {
-          replace: 'portalHost',
-          replaceWith: 'cdkPortalOutlet'
-        }
-      ]
-    }
-  ]
+  [TargetVersion.V6]: [{
+    pr: 'https://github.com/angular/components/pull/10257',
+    changes: [
+      {replace: 'cdkPortalHost', replaceWith: 'cdkPortalOutlet'},
+      {replace: 'portalHost', replaceWith: 'cdkPortalOutlet'}
+    ]
+  }]
 };

src/cdk/schematics/ng-update/data/class-names.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export interface ClassNameUpgradeData {
   /** The Class name to replace. */
@@ -21,35 +21,19 @@ export const classNames: VersionChanges<ClassNameUpgradeData> = {
     {
       pr: 'https://github.com/angular/components/pull/10161',
       changes: [
-        {
-          replace: 'ConnectedOverlayDirective',
-          replaceWith: 'CdkConnectedOverlay'
-        },
-        {
-          replace: 'OverlayOrigin',
-          replaceWith: 'CdkOverlayOrigin'
-        }
+        {replace: 'ConnectedOverlayDirective', replaceWith: 'CdkConnectedOverlay'},
+        {replace: 'OverlayOrigin', replaceWith: 'CdkOverlayOrigin'}
       ]
     },
 
     {
       pr: 'https://github.com/angular/components/pull/10267',
-      changes: [
-        {
-          replace: 'ObserveContent',
-          replaceWith: 'CdkObserveContent'
-        }
-      ]
+      changes: [{replace: 'ObserveContent', replaceWith: 'CdkObserveContent'}]
     },
 
     {
       pr: 'https://github.com/angular/components/pull/10325',
-      changes: [
-        {
-          replace: 'FocusTrapDirective',
-          replaceWith: 'CdkTrapFocus'
-        }
-      ]
+      changes: [{replace: 'FocusTrapDirective', replaceWith: 'CdkTrapFocus'}]
     }
   ]
 };

src/cdk/schematics/ng-update/data/constructor-checks.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export type ConstructorChecksUpgradeData = string;
 
@@ -17,15 +17,13 @@ export type ConstructorChecksUpgradeData = string;
  * automatically through type checking.
  */
 export const constructorChecks: VersionChanges<ConstructorChecksUpgradeData> = {
-  [TargetVersion.V8]: [
-    {
-      pr: 'https://github.com/angular/components/pull/15647',
-      changes: [
-        'CdkDrag', 'CdkDropList', 'ConnectedPositionStrategy', 'FlexibleConnectedPositionStrategy',
-        'OverlayPositionBuilder', 'CdkTable'
-      ]
-    }
-  ],
+  [TargetVersion.V8]: [{
+    pr: 'https://github.com/angular/components/pull/15647',
+    changes: [
+      'CdkDrag', 'CdkDropList', 'ConnectedPositionStrategy', 'FlexibleConnectedPositionStrategy',
+      'OverlayPositionBuilder', 'CdkTable'
+    ]
+  }],
   [TargetVersion.V7]: [],
   [TargetVersion.V6]: []
 };

src/cdk/schematics/ng-update/data/css-selectors.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export interface CssSelectorUpgradeData {
   /** The CSS selector to replace. */

src/cdk/schematics/ng-update/data/element-selectors.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export interface ElementSelectorUpgradeData {
   /** The element name to replace. */

src/cdk/schematics/ng-update/data/input-names.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export interface InputNameUpgradeData {
   /** The @Input() name to replace. */
@@ -31,86 +31,74 @@ export const inputNames: VersionChanges<InputNameUpgradeData> = {
         {
           replace: 'origin',
           replaceWith: 'cdkConnectedOverlayOrigin',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'positions',
           replaceWith: 'cdkConnectedOverlayPositions',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'offsetX',
           replaceWith: 'cdkConnectedOverlayOffsetX',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'offsetY',
           replaceWith: 'cdkConnectedOverlayOffsetY',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'width',
           replaceWith: 'cdkConnectedOverlayWidth',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'height',
           replaceWith: 'cdkConnectedOverlayHeight',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'minWidth',
           replaceWith: 'cdkConnectedOverlayMinWidth',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'minHeight',
           replaceWith: 'cdkConnectedOverlayMinHeight',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'backdropClass',
           replaceWith: 'cdkConnectedOverlayBackdropClass',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'scrollStrategy',
           replaceWith: 'cdkConnectedOverlayScrollStrategy',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'open',
           replaceWith: 'cdkConnectedOverlayOpen',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         },
         {
           replace: 'hasBackdrop',
           replaceWith: 'cdkConnectedOverlayHasBackdrop',
-          whitelist: {
-            attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']
-          }
+          whitelist:
+              {attributes: ['cdk-connected-overlay', 'connected-overlay', 'cdkConnectedOverlay']}
         }
       ]
     },

src/cdk/schematics/ng-update/data/method-call-checks.ts

@@ -6,34 +6,22 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export interface MethodCallUpgradeData {
   className: string;
   method: string;
-  invalidArgCounts: {
-    count: number,
-    message: string
-  }[];
+  invalidArgCounts: {count: number, message: string}[];
 }
 
 export const methodCallChecks: VersionChanges<MethodCallUpgradeData> = {
-  [TargetVersion.V6]: [
-    {
-      pr: 'https://github.com/angular/components/pull/10325',
-      changes: [
-        {
-          className: 'FocusMonitor',
-          method: 'monitor',
-          invalidArgCounts: [
-            {
-              count: 3,
-              message: 'The "renderer" argument has been removed'
-            }
-          ]
-        }
-      ]
-    }
-  ]
+  [TargetVersion.V6]: [{
+    pr: 'https://github.com/angular/components/pull/10325',
+    changes: [{
+      className: 'FocusMonitor',
+      method: 'monitor',
+      invalidArgCounts: [{count: 3, message: 'The "renderer" argument has been removed'}]
+    }]
+  }]
 };

src/cdk/schematics/ng-update/data/output-names.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {TargetVersion} from '../target-version';
-import {VersionChanges} from '../upgrade-data';
+import {TargetVersion} from '../../update-tool/target-version';
+import {VersionChanges} from '../../update-tool/version-changes';
 
 export interface OutputNameUpgradeData {
   /** The @Output() name to replace. */