Skip to content

Commit 0f296db

Browse files
committed
perf(material/slider): use flex to position tick marks
1 parent 980f9ba commit 0f296db

File tree

5 files changed

+2
-21
lines changed

5 files changed

+2
-21
lines changed

src/material/slider/slider-thumb.scss

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,3 @@
22
height: 100%;
33
width: 100%;
44
}
5-
6-
.mat-mdc-slider .mdc-slider__tick-marks {
7-
justify-content: start;
8-
.mdc-slider__tick-mark--active,
9-
.mdc-slider__tick-mark--inactive {
10-
position: absolute;
11-
left: 2px;
12-
}
13-
}

src/material/slider/slider.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
<div class="mdc-slider__tick-marks" #tickMarkContainer>
1212
@if (_cachedWidth) {
1313
@for (tickMark of _tickMarks; track i; let i = $index) {
14-
<div
15-
[class]="tickMark === 0 ? 'mdc-slider__tick-mark--active' : 'mdc-slider__tick-mark--inactive'"
16-
[style.transform]="_calcTickMarkTransform(i)"></div>
14+
<div [class]="tickMark === 0 ? 'mdc-slider__tick-mark--active' : 'mdc-slider__tick-mark--inactive'"></div>
1715
}
1816
}
1917
</div>

src/material/slider/slider.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ $_mat-slots: (tokens-mat-slider.$prefix, tokens-mat-slider.get-token-slots());
282282
display: flex;
283283
height: 100%;
284284
justify-content: space-between;
285-
padding: 0 1px;
285+
padding: 0 2px;
286286
position: absolute;
287287
width: 100%;
288288
}

src/material/slider/slider.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -587,13 +587,6 @@ export class MatSlider implements AfterViewInit, OnDestroy, _MatSlider {
587587
trackStyle.transform = styles.transform;
588588
}
589589

590-
/** Returns the translateX positioning for a tick mark based on it's index. */
591-
_calcTickMarkTransform(index: number): string {
592-
// TODO(wagnermaciel): See if we can avoid doing this and just using flex to position these.
593-
const translateX = index * (this._tickMarkTrackWidth / (this._tickMarks.length - 1));
594-
return `translateX(${translateX}px`;
595-
}
596-
597590
// Handlers for updating the slider ui.
598591

599592
_onTranslateXChange(source: _MatSliderThumb): void {

tools/public_api_guard/material/slider.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export class MatSlider implements AfterViewInit, OnDestroy, _MatSlider {
2828
_cachedLeft: number;
2929
// (undocumented)
3030
_cachedWidth: number;
31-
_calcTickMarkTransform(index: number): string;
3231
// (undocumented)
3332
readonly _cdr: ChangeDetectorRef;
3433
color: ThemePalette;

0 commit comments

Comments
 (0)